From:   Zi Yan <ziy@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linuxppc-dev@lists.ozlabs.org,
        virtualization@lists.linux-foundation.org,
        iommu@lists.linux-foundation.org, Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        Eric Ren <renzhengeek@gmail.com>
Subject: Re: [RFC PATCH v3 2/8] mm: compaction: handle non-lru compound pages properly in isolate_migratepages_block().
Date:   Thu, 13 Jan 2022 11:23:37 -0500
Message-ID: <99D30A79-7B57-4FCB-8C7A-7F93B66490E6@nvidia.com>
In-Reply-To: <71108865-5368-4725-AA5A-35A57C350D77@nvidia.com>
References: <20220105214756.91065-1-zi.yan@sent.com>
 <20220105214756.91065-3-zi.yan@sent.com>
 <a5e029e8-f646-a414-f4f4-ba573171642f@redhat.com>
 <71108865-5368-4725-AA5A-35A57C350D77@nvidia.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_00D2A4F3-896C-489B-A3C9-7A9A87B83B6C_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TpfSgzn2RU5Z+IuegFaTKSXjk7PMPiUz9sMighlAK/neqZsQG9PlA3Fkw8Pw?=
 =?us-ascii?Q?xIKX5zl1pUCCuzBriDzD0hSEmsYvQIpyDADMofkIWmyuX1OimKFJbrBfekxp?=
 =?us-ascii?Q?Xb1YzvOTxsX9mguuh6XBujvNtHbtotHj7SVFnZeT0MQhsjyhDrZzpvwM5QXj?=
 =?us-ascii?Q?RJQlI0Jm/rJMbEZ3ffXNVHwMA2mrUnGbsJetC2nY6NQxTsmybUuFWhmR9J6m?=
 =?us-ascii?Q?4ijThbVcBi9jKTpEhQshqpuqPA20hPrQWsRGosu5diefZrIU211dTOsMimf/?=
 =?us-ascii?Q?SnOG/jC6yjkmX6lcCndwMolB5tyY+PMkNO2ZC3yuFWN0IOzp3yILSjgAq+3W?=
 =?us-ascii?Q?A6rqK7j0tLY/qicIBwCrIN3byv4vF0h79CR1QzwIoBIDu6BrAMq7OXIRPzc7?=
 =?us-ascii?Q?uOzTTf+iObj8VFr3Pj8TUJjR13cuiDcWBNmUM7B7ect61BfosbQq7V761TKg?=
 =?us-ascii?Q?KrEz5+fCZd8XEu64z6yUk5QenrxkEoTBSw6rmQKbDsQaJBd3viBSWu11bbHZ?=
 =?us-ascii?Q?WR9lhahk5DbVraXbGJScVwocdaetv08Ls2kF8dTpbvc+eirkijR17pnyVXIK?=
 =?us-ascii?Q?Q6mDHmbefzWYFJ1pujTw3Tw5VKeS9X6Cfbd04tRw50ZVdrVDWlGYK0k6/Rln?=
 =?us-ascii?Q?pUkpcttu/T3gzUIHpbxwNmPyicKf8SjgMp1CfFiUIgasff3a8yrY+e9GPaNg?=
 =?us-ascii?Q?4BXrzKaaR4qwFD9IBRyMQsDHZXHQZPxBUee7uQ/Tabi05zBk/uYXfiH7OYwc?=
 =?us-ascii?Q?xeKQEEDIBHK3ngrhk4XuU72IGUwSTKwsHeQMLBffrwqXg+dQ4lwJ2OnnY5hi?=
 =?us-ascii?Q?wxy09DzNt46HEelSncmtPUNCl2gE59bzAL3SfD7VGXi8vrnJtPVo9kPuFRix?=
 =?us-ascii?Q?yRjgvXMw3FqQAeQjkFjD8ZVfCuzqB0nRBA+QoE/AEY7mEX6slozxEeIeWBdp?=
 =?us-ascii?Q?hnpT81iUFVyYKYdK1kulfOrMUDKx2BGy1+dOHilS56CjGWDRQKRpaBrSwkJc?=
 =?us-ascii?Q?9GPQZniT8nzyoBnJ88uvxkMoWpyAn6vxqAn3R/+8UjEPavqg27XQTfbeHKp5?=
 =?us-ascii?Q?9IJrWGJZbkXQbjtOYLH88wXdDVGrfiZSU8avsfFkzX7j7wQ9ApqNV3otKyb0?=
 =?us-ascii?Q?guhktO2iHlBrtLv4Y81C4mK5JntwoEK+mRRrctzxgubKuMC8bxwDRDBu9KsN?=
 =?us-ascii?Q?AzYq5/PVXR5mcq53wa9E81dn9Sq5uHNNGfN36iDo0QHGW6CqG0maYqH7OyQx?=
 =?us-ascii?Q?IuESs7NlHSgfzHQzNq/VVQli2fyjflz+SzqyIjCccKGJsBQCu4H9K729nNlF?=
 =?us-ascii?Q?e1js3ILMg/T0Yi5RT8TAfcD7VfN+nrDbX6EDebaX5V9lxEHQz7BkcOff1WLL?=
 =?us-ascii?Q?11+4H421CjA5Bi6xspqhpmM6dEoV1HvUrciscLBRPdKeEwwkrCMsOkoOd+px?=
 =?us-ascii?Q?WFw0vcUDxqj+5FzQP/NiKkjLB0Mu9erv4KwVpbNTZ31U8sb5lpQMx+gTj+Ww?=
 =?us-ascii?Q?MFybLxzaVNpWPp5YMptkA2YUqjrQyLWAjr5RnCBDTqxj9Ae4KcpGA2KPQvf/?=
 =?us-ascii?Q?9r3OH8ulpQnBzO+5Oik=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab17cd73-f38c-4fbe-6f60-08d9d6b10eb2
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 16:23:39.5484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 152eqzJOxbMsaXhGxTAna4VX/pQQafU2rGuVGq9vE/FX86wT1oWVHDnGgAJfCHv2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4637
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_00D2A4F3-896C-489B-A3C9-7A9A87B83B6C_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 13 Jan 2022, at 9:57, Zi Yan wrote:

> On 12 Jan 2022, at 6:01, David Hildenbrand wrote:
>
>> On 05.01.22 22:47, Zi Yan wrote:
>>> From: Zi Yan <ziy@nvidia.com>
>>>
>>> In isolate_migratepages_block(), a !PageLRU tail page can be encounte=
red
>>> when the page is larger than a pageblock. Use compound head page for =
the
>>> checks inside and skip the entire compound page when isolation succee=
ds.
>>>
>>
>> This will currently never happen, due to the way we always isolate
>> MAX_ORDER -1 ranges, correct?
>
> You are right.
>
>>
>> Better note that in the patch description, because currently it reads
>> like it's an actual fix "can be encountered".
>>
>
> Will do. This is a preparation patch for the upcoming commits.

I will drop this one too. Like you mentioned in [1], there are no
non-lru migratable compound pages. This is only used by my local
test code.

[1] https://lore.kernel.org/linux-mm/970ca2a4-416d-7e8f-37c7-510c5b050f4b=
@redhat.com/


>
>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>> ---
>>>  mm/compaction.c | 10 +++++++---
>>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/mm/compaction.c b/mm/compaction.c
>>> index b4e94cda3019..ad9053fbbe06 100644
>>> --- a/mm/compaction.c
>>> +++ b/mm/compaction.c
>>> @@ -979,19 +979,23 @@ isolate_migratepages_block(struct compact_contr=
ol *cc, unsigned long low_pfn,
>>>  		 * Skip any other type of page
>>>  		 */
>>>  		if (!PageLRU(page)) {
>>> +			struct page *head =3D compound_head(page);
>>>  			/*
>>>  			 * __PageMovable can return false positive so we need
>>>  			 * to verify it under page_lock.
>>>  			 */
>>> -			if (unlikely(__PageMovable(page)) &&
>>> -					!PageIsolated(page)) {
>>> +			if (unlikely(__PageMovable(head)) &&
>>> +					!PageIsolated(head)) {
>>>  				if (locked) {
>>>  					unlock_page_lruvec_irqrestore(locked, flags);
>>>  					locked =3D NULL;
>>>  				}
>>>
>>> -				if (!isolate_movable_page(page, isolate_mode))
>>> +				if (!isolate_movable_page(head, isolate_mode)) {
>>> +					low_pfn +=3D (1 << compound_order(head)) - 1 - (page - head);
>>> +					page =3D head;
>>>  					goto isolate_success;
>>> +				}
>>>  			}
>>>
>>>  			goto isolate_fail;
>>
>>
>> -- =

>> Thanks,
>>
>> David / dhildenb
>
>
> --
> Best Regards,
> Yan, Zi


--
Best Regards,
Yan, Zi

--=_MailMate_00D2A4F3-896C-489B-A3C9-7A9A87B83B6C_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmHgUgkPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK5FMQALOMRAoZNz8wqr/FszEJvt0Y+/WKSOwIp59F
xDsF4QztnneizNkbmSdhf6+KpxdyYK+xyOSto8LbgY/Py4WjMy9j/rMZuyZa09QR
zx6VX27qZRQoDxypiWAzOg/k9l/7LeTSR79sOHTRNDVxcHzH9Jci1PKD7myMySe8
aia8NMwhWWnUzMmqVlCsZRwzcHs9jjPHuMgIdWLtUTxA97V1eTFrJPGkxgzNZRBD
oySQIhl60LJxniiakcb4/cLQQr3SJvCIz6DDYGUcK6EbYuJ4PbciVMfgF3skiVnk
Tv6IErFnlh6Dkc+sjXc2MAgbMkJH2KpCyqV9nJncvF8MR3bfymUhaqia25wCWTk3
c6+iWSpu3Qmp1sjCOnCwMvNAgzqVIJ1/LYEzEGh0UbhgYY9j/p1rYi3G2NOtQkmc
OmqKzUYWFhEAY1PyERHfyWWd8ViTKn5DkUsOXY5WHpPw16XIL7n00uKzFENUZN3K
pM32J2foG48YWZBKCu78ljfXw/XfQlYgNNKdEJXSV5lCcekNbzYhYmAGE41lC6e7
H2BaNrcqm0iklrXOAmf10TuDbWb7iAUeKoo3XKKAO+QY4OIEnGuppunRA+F2RW2D
i6KooZGOZfl7Wspdh4U1Z7Zfg/zCcGXVqYQlvUdTY5LVr+8ONrv4yTxAr2no1BZ+
X8oMlNqi
=99D7
-----END PGP SIGNATURE-----

--=_MailMate_00D2A4F3-896C-489B-A3C9-7A9A87B83B6C_=--