From:   Rob Herring <robh@kernel.org>
To:     Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Cc:     linux-rpi-kernel@lists.infradead.org, kernel-list@raspberrypi.com,
        linux-kernel@vger.kernel.org, naush@raspberrypi.com,
        dave.stevenson@raspberrypi.com,
        linux-arm-kernel@lists.infradead.org, mchehab@kernel.org,
        laurent.pinchart@ideasonboard.com, lukasz@jany.st,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org
In-Reply-To: <20220112172719.1178446-2-jeanmichel.hautbois@ideasonboard.com>
References: <20220112172719.1178446-1-jeanmichel.hautbois@ideasonboard.com> <20220112172719.1178446-2-jeanmichel.hautbois@ideasonboard.com>
Subject: Re: [RFC PATCH 1/3] media: dt-bindings: media: Add bindings for bcm2835-unicam
Date:   Thu, 13 Jan 2022 10:29:34 -0600
Message-Id: <1642091374.239763.3647184.nullmailer@robh.at.kernel.org>
Precedence: bulk

On Wed, 12 Jan 2022 18:27:18 +0100, Jean-Michel Hautbois wrote:
> Introduce the dt-bindinds documentation for bcm2835 CCP2/CSI2 camera
> interface. Also add a MAINTAINERS entry for it.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> ---
> Dave: I assumed you were the maintainer for this file, as I based it on the
> bcm2835-unicam.txt file. Are  you happy to be added directly as the
> maintainer, or should this be specified as "Raspberry Pi Kernel
> Maintenance <kernel-list@raspberrypi.com>"
> ---
>  .../bindings/media/brcm,bcm2835-unicam.yaml   | 103 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 109 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.example.dts:24.31-32 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1413: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1579262

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.