MIME-Version: 1.0
References: <20220113031658.633290-1-imagedong@tencent.com>
In-Reply-To: <20220113031658.633290-1-imagedong@tencent.com>
From:   Song Liu <song@kernel.org>
Date:   Thu, 13 Jan 2022 09:07:32 -0800
Message-ID: <CAPhsuW5HLK=DoNWmROXrce+9AcNBDLhjuoXQy2T0A_DQ34PBfQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c
To:     menglong8.dong@gmail.com
Cc:     Shuah Khan <shuah@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, davemarchevsky@fb.com,
        linux-kselftest@vger.kernel.org,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>, imagedong@tencent.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 12, 2022 at 7:17 PM <menglong8.dong@gmail.com> wrote:
>
> From: Menglong Dong <imagedong@tencent.com>
>
> 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
> used, just remove them.
>
> Signed-off-by: Menglong Dong <imagedong@tencent.com>

Acked-by: Song Liu <songliubraving@fb.com>

> ---
>  tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> index 95d5b941bc1f..c9abfe3a11af 100644
> --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> @@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
>  {
>         void *data_end = (void *)(long) skb->data_end;
>         void *data = (void *)(long) skb->data;
> -       __u32 lport = skb->local_port;
> -       __u32 rport = skb->remote_port;
>         __u8 *d = data;
>         int err;
>
> --
> 2.34.1
>