From:   Song Liu <songliubraving@fb.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "John Fastabend" <john.fastabend@gmail.com>,
        "bjorn@kernel.org" <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] samples/bpf: xdpsock: Use swap() instead of open coding
 it
Thread-Topic: [PATCH] samples/bpf: xdpsock: Use swap() instead of open coding
 it
Thread-Index: AQHYCJnPDy4utsIJUkazfv4sYDNj26xhTiYA
Date:   Thu, 13 Jan 2022 18:59:24 +0000
Message-ID: <15D65AC9-F89D-4BA1-AEF7-DB111FE1165B@fb.com>
References: <20220113162228.5576-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20220113162228.5576-1-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vJsqHJj7J4xLHhhy1LlpYAwZhuaTfWio+zera/dedvCTUH0uTus1kj+CVf+/?=
 =?us-ascii?Q?oZZecvr1C2EGPYqjLxTbEVRcQt2dvETz1cATn//SHL7Ipqq2Dwn68nsBo5ox?=
 =?us-ascii?Q?sFx9NrTmi5pr3excy4o4O6iQ8OEN5iUc8RO9vs8ChpMb3i75UMy37ItCGmtU?=
 =?us-ascii?Q?OXtjY7coByYr48KGbVALk+uRhir60zyh7WdKhvKWYt0uCVpIYLH5EZBNRoPp?=
 =?us-ascii?Q?b99A8vFcNTAzco3hwanXdP2R5iTlEkLwuyiLERaOLgYksR+TuVl64Rau61We?=
 =?us-ascii?Q?Nnk8840GKtBWPK6dCLair4wHgp2af+CCb9/SZ5pYdz02JkxDoFOQQEv6tKuz?=
 =?us-ascii?Q?fvsoL9o5qqNQ2YRjHZB7AyRuYJiwrY+gHdhKC9YvZllEx/eID5JlFtQHz8AD?=
 =?us-ascii?Q?ZRGXSlufuV1fxketJit+szaNbDF3slfqy0q2PGBAxHd2WZ7BYJwe6MeoW4UC?=
 =?us-ascii?Q?8YqVbmvFmB+E/W81ghG9o206o33k9h6YRIb2LkCj9Mn+yuW7+OmPLq4rtz6b?=
 =?us-ascii?Q?85NxQsIaMvYrRvsYRVhhIgpmmYDQ08O6Vz4NO38bveBHI2eHCPDVjRowryKv?=
 =?us-ascii?Q?DsnJ1hhe77XY31iJrguB7UletvVUBKVCd8h1DGmaAB+naWiZ7bp6/K/Kqn97?=
 =?us-ascii?Q?B3vJNL0Y67ZzIC9/0lsI+IzZ8Tr+hEj+HaeuOO0/5CcgRXqDDJi1KFtnDBWY?=
 =?us-ascii?Q?dzDXKXXMegIBDj7Qum1aTts4Ybx0pLI00eBJEs5q4yzr0UhURHp/qa5HKDxN?=
 =?us-ascii?Q?6tyJW0yXVEnIqo9LqVB1iCC1pgT1AIEKKPjjK2poWLqVIfkfeaVt2xipGCpp?=
 =?us-ascii?Q?jM35kqE5p8CSqSSneSnAxJa1CPSgJkXlQWpNmUlNjfCP46AkZpvKjbg38CUW?=
 =?us-ascii?Q?xjDWgNH4VKM6LWZmuVR7ZB40A0uMisxGYcG6k40MMSefRRA8Zbc1Bd+c1Nqq?=
 =?us-ascii?Q?MSAq0HH+tJMpIFlk4srH1K5Z26UlZwgMAy/Lie8dvq6TLNKxXXjIcsD7wMfh?=
 =?us-ascii?Q?sj9Ak9YpOFpiXu0idB7Tv/4UjjfkmhAHMY5f5J/s0jHnHreDZITjxFGq+jtY?=
 =?us-ascii?Q?2EhU/ljwGpm2jmVyztPQbOleh8W8IXeitZ5DEhrRaf2jBUYHnHJL8wC0wiuP?=
 =?us-ascii?Q?H48R3jR0g47yHDT7XYlieNhuAU187m/0RxCkbeJ2k82m/30yviGqnp+hNFCF?=
 =?us-ascii?Q?+vygsVDytd78fI1trVff6PDBnrqlT22QaHO4m1ok6dKbA7QZ5vaiY3opMJIK?=
 =?us-ascii?Q?n2CEFxcMyk8xWPLGDtpux73QJSViJqO/5PPT+CaUk/6iLPgwmKLyfwKikqbz?=
 =?us-ascii?Q?75q8htGCJwB8b/CXuGPrRWzEGBTJdk6Wc3/y7tbqBrstX1EWApMAZL35ouql?=
 =?us-ascii?Q?98OG2o+DamWNTcx9HaosDKOsXQF6wDd59qe+xSq3J9kttzEPWFhaQpqWw14I?=
 =?us-ascii?Q?GAvnKeKMHa9fHRQANwhtKgLatygqjk0q8k9zlI+RgBF/tGQWNjQmWmkFpKpi?=
 =?us-ascii?Q?Nx+bTpbvuNJW+/OgDJaINGDEf0nIPfpKDGw5F/GqaY+kCDnwXyP4W7M9GJC+?=
 =?us-ascii?Q?VRXzwfKPXi7qKUlFFbtK3AfK9NnZ+Y+EfrSOt00lUCXHx+w1FIZLZO9fa8wU?=
 =?us-ascii?Q?p4uGvx3npGwYWBtCCyrdB9HAJIEnAAfai+5+ibHRt/RJpRAefN+Bz25/Aqoy?=
 =?us-ascii?Q?U+GQQw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3EA9C26153A0F844BBE60BE9F5DA479C@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c9b7a94-b0de-43b1-ba79-08d9d6c6d09d
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 18:59:24.1189
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oG8lx3dhSxI45qm95NhXgSjtPfotYr1nw8k05GWTZyNUgh9wZBJvOlEDvvmzf19V8tUyD6D2Z8/J3xcp/weCHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2411
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: J6fP54F6YnFbeKjUui8eUbry5m1kIrFv
X-Proofpoint-GUID: J6fP54F6YnFbeKjUui8eUbry5m1kIrFv
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-13_08,2022-01-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 priorityscore=1501
 suspectscore=0 mlxlogscore=993 spamscore=0 malwarescore=0
 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1015
 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201130119
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 13, 2022, at 8:22 AM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> 
> Clean the following coccicheck warning:
> 
> ./samples/bpf/xdpsock_user.c:632:22-23: WARNING opportunity for swap().
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: Song Liu <songliubraving@fb.com>