Date:   Thu, 13 Jan 2022 16:11:23 -0500
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Tejun Heo <tj@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ben Segall <bsegall@google.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Ingo Molnar <mingo@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Michal Hocko <mhocko@suse.com>, Nico Pache <npache@redhat.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Steve Sistare <steven.sistare@oracle.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        linux-mm@kvack.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [RFC 15/16] sched/fair: Account kthread runtime debt for CFS
 bandwidth
Message-ID: <20220113211123.c4csxg5srmkisqwr@oracle.com>
References: <20220106004656.126790-1-daniel.m.jordan@oracle.com>
 <20220106004656.126790-16-daniel.m.jordan@oracle.com>
 <Yd1w/TxTcGk5Ht53@hirez.programming.kicks-ass.net>
 <20220111162950.jk3edkm3nh5apviq@oracle.com>
 <Yd83iDzoUOWPB6yH@slm.duckdns.org>
 <20220113210857.d3xkupgmpdeqknhn@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220113210857.d3xkupgmpdeqknhn@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8z5m/dobTHNWyPQ8dkVS2GP/u40aTOfFj9n1oAWKBV/XLJf3E1S0fCJTmae2?=
 =?us-ascii?Q?FhdDPb2P5bob3VD8S+LVH/1Si0AUykg57OjWzNaS2oNBFyltXY0hv1LH3JRN?=
 =?us-ascii?Q?2pd/GRLPNX86wf9MYKxRAdqspPLinC6z7h5aDiLytXuwYbgx8fgtUSE03l/s?=
 =?us-ascii?Q?HE76aVeeEGCIskVPS8Ftvw9PSdFVQ+1qUbdVeyNfv+ocyDsumTBn1vcFyPCw?=
 =?us-ascii?Q?tg119jaqp8ulFSrYWmh4iB5yJwj5848+HdLvD36BQQ/rjWILu/Eos9ljTNbN?=
 =?us-ascii?Q?SmzpPA64NdQYvHi96r8i9uLutrBAczS78el2JRF1GRpbSQkwLrgVMY3RM7GP?=
 =?us-ascii?Q?3ScU/gG8za4WEigEy3tWzo1jXm7sSidYkequDHvLbuCo5+TL3in1o3LOgkSi?=
 =?us-ascii?Q?gX3Q6Y/Ag59/0WjM/jCIRbPqnyjCiNtCKeoQCD/zckf6+O52ovAwxsqCysDJ?=
 =?us-ascii?Q?TvZP9ut3n6dWBKl9DL27//E4d2bl3HWec2cYWFgK2SkI1UJgHpKJQGHwvNPK?=
 =?us-ascii?Q?Jn9eObJiK3D5eah6mblqgSZ613BkixAQTpfF+jsH32wN6M8CBPoP6S5ZsGsB?=
 =?us-ascii?Q?6dtrOSlBQerZd6F8s87syKfV5Ur5UmYWd3tf+EkDza1o08iNSaWtrdiiDzAQ?=
 =?us-ascii?Q?yAVM427zcvAE+DwNk0D/2xik4NFrjZoJSJAmkzbMywo+Mmwsns+XJA0Twcp6?=
 =?us-ascii?Q?sUVzDQcngZhtKxGlzFNa9j0eMH09V9aHdiV7mR58DVipQU9tQZI+WFX7hrDG?=
 =?us-ascii?Q?P14Sr+iQHLM/wwlFP8j/iMYb9lOoSEhyNIYhN2FMlYgj5+v664178giCbtCS?=
 =?us-ascii?Q?ftxjPXFzdSFr+Jisp/jKlfQCtZN0/r6JVMrlWV5TSsaRCiaWtLF5myCPXEMY?=
 =?us-ascii?Q?iWPj6WRTG2csl1BKmBRUU+ycCzXs5BjMfIEsVIK1kAVq7ovIek5lbnev3EkS?=
 =?us-ascii?Q?idOKtw6gtkganBES6bRVJfu6npRPtm00zr8Ps1VtcoTjbBpuEKr4/uqwqDtV?=
 =?us-ascii?Q?S20vxzn3vdBN+AzXXXiwQVkGGo2BTd5atsCSstlW8v0wCC2ZnWTC9B9CuHGa?=
 =?us-ascii?Q?M/IhPDIOU+kok+HLRWIdU07NrBCPh7IaGx8RJR+YTb0zNr/SrZdamZvKRWde?=
 =?us-ascii?Q?MNIcuqY2YckncK5SmBdodn2bajFl+YdXW6cMB5dyNXvB6QY85VyisC1Bh675?=
 =?us-ascii?Q?TeZxMZvOK8O5lIzYsipI8bdUlQedFhk1eKS78Xl7vNf4I7R5O0K6X0E1K74t?=
 =?us-ascii?Q?Dm2UM5Ol9xqjpVLYCpz2qgAjTOjxUC3XIAc3BJBquu4FuifnPEH9DiRQ/gg6?=
 =?us-ascii?Q?IyueBQcdNhgVb7sp62FGhuoCk5tduL8p9KR441LPkTQjz3kBMcQf4FGbb8je?=
 =?us-ascii?Q?olwDkyUtLY885TN4jxdFHpmbdhLK9HwFQ/Kw//4AuCBp0MWC7JtrcM+nqYUX?=
 =?us-ascii?Q?3qeduVYWKiUIuFakmwTWiy/i2pPY16kK8rpXe+EWUyaARW4mTsMnuSp0gSRw?=
 =?us-ascii?Q?y6ma3bat1sSU48ujgtMA+S9LJLHwkLioyIbMpKJUwtJZPv5FMRvlmWUq0ed8?=
 =?us-ascii?Q?34Ih0lb8fI6oc0MCu+ZMmly9Mo5u+auvf4WdP78+0qF9YzZs1fRxRy7JhIQt?=
 =?us-ascii?Q?G2RB2buP3NzYqd/dFPrX5sE1sa3FijKXKKXBPJLpl4KDretQzeZHxq6ea1wa?=
 =?us-ascii?Q?i4pUZuZg0lr4RiGMR1/PggwzaH8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53c66d97-60cb-40a2-4b6a-08d9d6d9437b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 21:11:27.9599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0oRVe9g1VnVZ16sKWVFIQscPBb+/6/ztnUo923BeRwsDbGCwY44IhipEVDftJdvcojzgtB5CQui9GcOYxoEnoX/UOR+tMXpLO3UStS66FK8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5612
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10226 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201130130
X-Proofpoint-GUID: H5PW4-w-ZZaaSpH600va4HadxVy6ZcEc
X-Proofpoint-ORIG-GUID: H5PW4-w-ZZaaSpH600va4HadxVy6ZcEc
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 13, 2022 at 04:08:57PM -0500, Daniel Jordan wrote:
> On Wed, Jan 12, 2022 at 10:18:16AM -1000, Tejun Heo wrote:
> > If we're gonna do this, let's please do it right and make weight based
> > control work too. Otherwise, its usefulness is pretty limited.
> 
> Ok, understood.
> 
> Doing it as presented is an incremental step and all that's required for
> this.  I figured weight could be added later with the first user that
> actually needs it.
> 
> I did prototype weight too, though, just to see if it was all gonna work
> together, so given how the discussion elsewhere in the thread is going,
> I might respin the scheduler part of this with another use case and
> weight-based control included.
> 
> I got this far, do the interface and CFS skeleton seem sane?  Both are

s/CFS/CFS bandwidth/

> basically unchanged with weight-based control included, the weight parts
> are just more code on top.
> 
> Thanks for looking.