Date:   Thu, 13 Jan 2022 22:09:33 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Zeng Guang <guang.zeng@intel.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Jethro Beekman <jethro@fortanix.com>,
        Kai Huang <kai.huang@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Robert Hu <robert.hu@intel.com>,
        Gao Chao <chao.gao@intel.com>
Subject: Re: [PATCH v5 8/8] KVM: VMX: Resize PID-ponter table on demand for
 IPI virtualization
Message-ID: <YeCjHbdAikyIFQc9@google.com>
References: <20211231142849.611-1-guang.zeng@intel.com>
 <20211231142849.611-9-guang.zeng@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211231142849.611-9-guang.zeng@intel.com>
Precedence: bulk

On Fri, Dec 31, 2021, Zeng Guang wrote:
> +static int vmx_expand_pid_table(struct kvm_vmx *kvm_vmx, int entry_idx)
> +{
> +	u64 *last_pid_table;
> +	int last_table_size, new_order;
> +
> +	if (entry_idx <= kvm_vmx->pid_last_index)
> +		return 0;
> +
> +	last_pid_table = kvm_vmx->pid_table;
> +	last_table_size = table_index_to_size(kvm_vmx->pid_last_index + 1);
> +	new_order = get_order(table_index_to_size(entry_idx + 1));
> +
> +	if (vmx_alloc_pid_table(kvm_vmx, new_order))
> +		return -ENOMEM;
> +
> +	memcpy(kvm_vmx->pid_table, last_pid_table, last_table_size);
> +	kvm_make_all_cpus_request(&kvm_vmx->kvm, KVM_REQ_PID_TABLE_UPDATE);
> +
> +	/* Now old PID table can be freed safely as no vCPU is using it. */
> +	free_pages((unsigned long)last_pid_table, get_order(last_table_size));

This is terrifying.  I think it's safe?  But it's still terrifying.

Rather than dynamically react as vCPUs are created, what about we make max_vcpus
common[*], extend KVM_CAP_MAX_VCPUS to allow userspace to override max_vcpus,
and then have the IPIv support allocate the PID table on first vCPU creation
instead of in vmx_vm_init()?

That will give userspace an opportunity to lower max_vcpus to reduce memory
consumption without needing to dynamically muck with the table in KVM.  Then
this entire patch goes away.