From:   Song Liu <songliubraving@fb.com>
To:     "davidcomponentone@gmail.com" <davidcomponentone@gmail.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "andrii@kernel.org" <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "kpsingh@kernel.org" <kpsingh@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yang Guang <yang.guang5@zte.com.cn>,
        "Zeal Robot" <zealci@zte.com.cn>
Subject: Re: [PATCH] libbpf: remove unneeded conversion to bool
Thread-Topic: [PATCH] libbpf: remove unneeded conversion to bool
Thread-Index: AQHYCNruv6K1qocsPE+7URuTztx2EaxhrCWA
Date:   Fri, 14 Jan 2022 00:37:37 +0000
Message-ID: <229F1668-2FE9-4B09-8314-DFB13B3D0A12@fb.com>
References: <2010e0898586ad83321e8d84181789123e2fe4e4.1642062557.git.davidcomponentone@gmail.com>
In-Reply-To: <2010e0898586ad83321e8d84181789123e2fe4e4.1642062557.git.davidcomponentone@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Cd5+J3GY30/NGaJcpbnzBXk4iR+Iz+J7/DkwAX4FAJXUAb1KPq/8QqGW9jQN?=
 =?us-ascii?Q?CRyiAS+vs+GPWcLEklEap6x6Sljr0xIFkW6XRn29846ESuHlGbqpEey0HyVI?=
 =?us-ascii?Q?9mDv+92MwXFEXdD2+zwg7Y+pub3kNzeuM/8ZHGaZ8RLio1vX6zxbnZA60nEo?=
 =?us-ascii?Q?qQYSLLf3JrkxBDUhnbMRqUOxk7oRkneQIUWDciMdQmaH0/+YDhLTOiUhapXG?=
 =?us-ascii?Q?Fwj/AsZ2QAbCDph2n1qfr9OmabIpXHC3Ht5wPWyTQk5xEjVGlJXEmG89W8N3?=
 =?us-ascii?Q?PCAeVMqhhg3hfQ270rJrDX04c3DjHQfYLKd8urHRmTkMo4yPeM8jpkg6jaNF?=
 =?us-ascii?Q?Bf7QE7tHZW0KGL/U71DI6SaP7CwY0/s7X3qtZ1sJsmdCfqRM6wmBalAWMdQC?=
 =?us-ascii?Q?pIPapZyotYxIHzvYIz0IpaDMHsMeCdDfXJDSDzI4Q5MqgObJIhr9Wgxeot+l?=
 =?us-ascii?Q?ziuRcl2TST5ARVknuNmn11Y02jEEoWrFbLS/RUoKh4j1qLhIlonNjclH6P4k?=
 =?us-ascii?Q?UUdDHqDIUMqaYk8VABceTqSQIV9+cROQrN9JHEIou2wnimBeNHcC5XJdV7xs?=
 =?us-ascii?Q?aFKEYMs4BK/B79ivCatPFRwZMfl9hNWSM5P8umJs4HDK1Wa+GwuCxDj8OUYq?=
 =?us-ascii?Q?YOqpPIWw1m6xTlQgPDa6YoqYg5YjFiKNCuizkuBmfxk8a2PZNcem8liNjKZl?=
 =?us-ascii?Q?+6EvoJtn3OQ+79xZKUumNUvGSxx79l1cnsB0Ms2y4QhH7GAm1cdJpqaqwzao?=
 =?us-ascii?Q?WSsiV560q+TiZgbj9mkviBiwhtrsMezYmeRPbeOUIFLxzcoxCimFKurRcjYm?=
 =?us-ascii?Q?BDYzumzvCDUvmSAn0gBH+zPoxZk83zy7xnuDmKSBSgJ6YwGBFHOo7hL7mqJG?=
 =?us-ascii?Q?nUN7xd2tQlFrHnWMOKn6Rfi/Hj6JYloKAs6tkV/4iT/NPjhe/46Xjy5pbkSE?=
 =?us-ascii?Q?j6uGl4nIpiy/Mq1WrfjtivH2aNKRfbF7+kAFKc0/NbvZ9zXUhWBQMT26AM38?=
 =?us-ascii?Q?UpUzvPnwKBeXHQEorcqIfCreAI0pz6+bBdNYDNbAij6cdqvdN+I1ll2aU3Hp?=
 =?us-ascii?Q?WM3pAjQkEqWu5w7pMz2nKe9/ioSGmiJRh38+d3Gg/j0tLBrfbgs7S9qZ09Qw?=
 =?us-ascii?Q?DoWcsqjFtwBzfN4+rOufLIuijgLijiZehY2ZgsUjh1W9ZrvcrueYwmgkp/23?=
 =?us-ascii?Q?kWGJSrVMDy3twW+lkNZB+lRmfHvNCyB4SvjpV2YiOgEs7z2KK0H2Sz4A49bf?=
 =?us-ascii?Q?Ucs5PVyXljA4EU7VX8PDbmiRwRJzubiqXLbtR/zUSXRqIB0g0MNjqYN73a8M?=
 =?us-ascii?Q?CyHZTZo8K6qCKv31DfZvWE36zuQH/Od6dlasnFqEVwwru7oVEWJDO0OhYKIA?=
 =?us-ascii?Q?mgvwFU/DXsRZVecXQ17/6cE4fhwO79ofz+wyxhW603mdZpTTABONecCbaHeP?=
 =?us-ascii?Q?Ik+lbFh2QujeDKv0ONSfbToSBRB1JBWVm6vICGhhcKyEffF70b5FHSIjxSop?=
 =?us-ascii?Q?IRgcpC+NMGgw+KZWTK7CTSLAKrc+Q40YaSeCaHMb9kF1OkaFG6eH2KVyv6nA?=
 =?us-ascii?Q?sFqRPPotLmASi2FCGCAA4YmJZne9Ey9h05+FVtJBIkaEhQu2MeedL4MsHaz/?=
 =?us-ascii?Q?fx3Kk5CWRMdtQZYVmNmKJ9VjZoWRYgqm1tnnnaxkEidi1X6mtXPZVV2ZblJQ?=
 =?us-ascii?Q?SyLxng=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3B735A5D4EC951499BE530A717C08C91@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c350c7b3-a2fc-4b5a-560a-08d9d6f6108a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2022 00:37:37.6654
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RIxRy1V0m4IsEF6kbCyRbHR9jyh0cu/mcGC6cot3tglnB8Kl9T3RkDcBBELq1rmSQtmPBLwy45FzrwUdvb92jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR15MB4294
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: xkSxqNaYilgBq8bpkOJySqiNCWil62rw
X-Proofpoint-GUID: xkSxqNaYilgBq8bpkOJySqiNCWil62rw
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-13_10,2022-01-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 priorityscore=1501
 suspectscore=0 mlxlogscore=868 spamscore=0 malwarescore=0
 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1015
 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201140001
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 13, 2022, at 4:07 PM, davidcomponentone@gmail.com wrote:
> 
> From: Yang Guang <yang.guang5@zte.com.cn>
> 
> The coccinelle report
> ./tools/lib/bpf/libbpf.c:1653:43-48:
> WARNING: conversion to bool not needed here
> 
> Relational and logical operators evaluate to bool,
> explicit conversion is overly verbose and unneeded.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> Signed-off-by: David Yang <davidcomponentone@gmail.com>

I think this change has been NACK'ed multiple times. 

I guess it is a good idea NOT to send it again. 

Thanks,
Song

> ---
> tools/lib/bpf/libbpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 7f10dd501a52..f87787608795 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -1650,7 +1650,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,
> 				ext->name, value);
> 			return -EINVAL;
> 		}
> -		*(bool *)ext_val = value == 'y' ? true : false;
> +		*(bool *)ext_val = value == 'y';
> 		break;
> 	case KCFG_TRISTATE:
> 		if (value == 'y')
> -- 
> 2.30.2
>