Date:   Thu, 13 Jan 2022 18:17:13 -0800 (PST)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
cc:     guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org,
        linux@armlinux.org.uk, lenb@kernel.org, robert.moore@intel.com,
        linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, patches@amperecomputing.com,
        scott@os.amperecomputing.com, darren@os.amperecomputing.com,
        james.morse@arm.com, Ilkka Koskinen <ilkka@os.amperecomputing.com>
Subject: Re: [PATCH v3 2/2] ACPI: AGDI: Add driver for Arm Generic Diagnostic
 Dump and Reset device
In-Reply-To: <alpine.DEB.2.22.394.2201051530290.2489@ubuntu200401>
Message-ID: <alpine.DEB.2.22.394.2201131801380.3166@ubuntu200401>
References: <20211231033725.21109-1-ilkka@os.amperecomputing.com> <20211231033725.21109-3-ilkka@os.amperecomputing.com> <20220105104602.GA4752@lpieralisi> <alpine.DEB.2.22.394.2201051530290.2489@ubuntu200401>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Content-Type: text/plain; charset=US-ASCII; format=flowed
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Woq/gpJb6CzSTV/YrhKda9hGMBqgQ4b2y3jXVt2QBrBz3Q6oAk1he8uusZz8?=
 =?us-ascii?Q?D4PvmdiEkyEulxIM7cq/RuAJ5TRICjPRlAii3u9jRdPTvBJ/NZim4xOIfeNx?=
 =?us-ascii?Q?ra8lxSLeszxLc1Qj/otr4xhxyOJL2Si1lHTm38fYoLYqsTjpnLWFPu+EA0i5?=
 =?us-ascii?Q?Wkv9fqUb8gJpHWQmzNSsrzgsKkLs15mEuTAlsNs0okCM4g6AtYpzXPLMzY3Z?=
 =?us-ascii?Q?tmQ0VzeoLGPKj+0eQ2tZdYNLkPtK8JmrhRCXMPxKHJnmHUphGiRZYPPAfKjO?=
 =?us-ascii?Q?+yiYVeJDHptuGacSE+PeMelD6jWftvAg5w8yo4twvWP80FxsCapE73Lr1LmO?=
 =?us-ascii?Q?ZaPnHre1ffSEs7JP2sw9p5M4BoUlnFRQWii1RguuLqON1tgYzoipJeTp0lvs?=
 =?us-ascii?Q?WVdaNYw1kavY2kHLjADlTP7nTcZoKUZM94Qzd4T0+15xw/QGkDnU5rWMOPLm?=
 =?us-ascii?Q?iMJMfXoajsNvDQbDydS/qAg0Apj3TlYZvBidI8njP4cpGyaWebz26wA4o37e?=
 =?us-ascii?Q?q6LXbGfbriZ1lAqoOqbzCrdVkX6uLJypUBsVkAT1EyjBDsO+GnJjEOJiWema?=
 =?us-ascii?Q?O7Qfyl9BA5bMdjQyRbhHFLi0X3g9kRloq0tNRnvFP4EwwTU67Oxlzvw7AaQ3?=
 =?us-ascii?Q?ZiJ5mOI8WKJuSvFMr1KCTJTTQXITYuxintwlToS4WdsIYty9HniXnTyHBJ8T?=
 =?us-ascii?Q?nYju+K9LMogoLL6s30gN97oHKVx2WITDZXSeEMMcSChbLW/7LnzE+MsG/Du7?=
 =?us-ascii?Q?boqa/TCyZuwIYWSrMjTKq5onquDwZfvCzWbffxT/m5py60ZsRrIo/89fhR1X?=
 =?us-ascii?Q?NJW+CfvxqaXV8212ot4VqQIvp2TYoJLJAtL3zMjk3FzW6zzDglZPe/9BZMGv?=
 =?us-ascii?Q?8l9+4ncNRvMMRfzPXaqzYUOO6Ey8rWwLbhVYRVkU40HzbxFGlNXtKp7Af8/l?=
 =?us-ascii?Q?brgL+gPKByO+i+WktoaY1VMIG08umofZZR72AOPoQ7TjN7cMHg/GNRfPpRLA?=
 =?us-ascii?Q?rc6s/HakWcWOWN9X6Pi8XyHLretzjB4u6QjOFOZX72h8COKAj0AV2w06p7fG?=
 =?us-ascii?Q?ugCAoE7QHLzwtjwp4QfNCEwdRoIaEdFEoWQcfSjBlrhqGD+FSHuOysAmg8p1?=
 =?us-ascii?Q?ni0gRBU6jJktRrY7a5bLeuUB2dKQApcYxHNBsbYbMnpzoTUHw2XnxpP81ncS?=
 =?us-ascii?Q?0dGm5lT2CGFAKoPHvQ9uJHuSuLv3GbFR4bqeVp+CxTzaUUdhBlxls8xw2T3/?=
 =?us-ascii?Q?NrHgwKu9rPFnMAcnKCdLpMF8oiGPakY08vb1ApKkwUs41J6NVS4zOqULztnd?=
 =?us-ascii?Q?3kZSPYyK9hBfoJ9tOYUzqNTvm57fmsam8ZR1w+RdpqHCWsauGaHI8weWAfbd?=
 =?us-ascii?Q?Xl4kT2jQiqMxLly04CXdio+HTbXtjrJ1bl6xNdgF2foVgeC5r2Iyts/HMxD6?=
 =?us-ascii?Q?nHkfp6gRLt0RXnKXxq2sm4OuTKfFB9mWW0N5OvH1IIXW41RbT+YqQvY4OH0+?=
 =?us-ascii?Q?WBeuUnEk4YDSCwWltW5w4XW8EzRaSyPKVSxS0L+iUFgpkIu1z0wy7KWWQMyX?=
 =?us-ascii?Q?r6vTLyNG8JASxk46JOxdGcIZSfoql5DyrevgwWmXw74/Z8fFNMEifOC2EJLk?=
 =?us-ascii?Q?nASP6UON/Oe0jGizslinn0kWfWgrD1mzOfYZmArELp5p2XMY8jowIq6txdt9?=
 =?us-ascii?Q?Kq4JHTgWlDscvg591/3VzaDDAXJTVHjwUe+TsWDkUAMMvpQAKTHxhxZ2Jb5k?=
 =?us-ascii?Q?cJallptX8w=3D=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 201b03aa-d7fe-4263-4196-08d9d70404b8
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 02:17:31.3504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kxhQYReU3OUGAyNQrp6D4TuTTpqDkrrbqy5YTnI8hvJAq+9VjY6H4Q0ohhHZpavSbi2o8fv4Pcz2twci+dmwcMTqrY/XryzT19bPDfazRTCIymzV7CKFnK9UgxZxGWS0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR01MB2828
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Lorenzo,

On Wed, 5 Jan 2022, Ilkka Koskinen wrote:
>
> Hi Lorenzo,
>
> On Wed, 5 Jan 2022, Lorenzo Pieralisi wrote:
>> [+James, for SDEI bits]
>> 
>> On Thu, Dec 30, 2021 at 07:37:25PM -0800, Ilkka Koskinen wrote:
>>> ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices
>>> Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to
>>> issue diagnostic dump and reset via an SDEI event or an interrupt.
>>> This patch implements SDEI path.
>>> 
>>> [0] https://developer.arm.com/documentation/den0093/latest/
>>> 
>>> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
>>> ---
>>>  drivers/acpi/arm64/Kconfig  |   8 +++
>>>  drivers/acpi/arm64/Makefile |   1 +
>>>  drivers/acpi/arm64/agdi.c   | 125 ++++++++++++++++++++++++++++++++++++
>>>  3 files changed, 134 insertions(+)
>>>  create mode 100644 drivers/acpi/arm64/agdi.c

<snip>

>>> diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c
>>> new file mode 100644
>>> index 000000000000..6525ccbae5c1
>>> --- /dev/null
>>> +++ b/drivers/acpi/arm64/agdi.c

<snip>

>>>
>>> +static int __init agdi_init(void)
>>> +{
>>> +	int ret;
>>> +	acpi_status status;
>>> +	struct acpi_table_agdi *agdi_table;
>>> +	struct agdi_data pdata;
>>> +	struct platform_device *pdev;
>>> +
>>> +	if (acpi_disabled)
>>> +		return 0;
>> 
>> Why don't we call agdi_init() from acpi_init() as we do for IORT/VIOT ?
>> 
>> I don't think it is necessary to add a device_initcall(), with related
>> ordering dependencies.
>
> That's a good point. I change it.

Actually, I looked at this more carefully. acpi_init() is called in 
subsys_initcall() while sdei_init() is called in subsys_initcall_sync(). 
That is, if I call this function in acpi_init(), SDEI driver won't be 
ready and this driver fails to register the event.

Cheers, Ilkka