Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1634280331-4150-1-git-send-email-wangqing@vivo.com>
References: <1634280331-4150-1-git-send-email-wangqing@vivo.com>
Subject: Re: [PATCH RESEND] clk-si5341: replace snprintf in show functions with sysfs_emit
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     mike.looijmans@topic.nl, Qing Wang <wangqing@vivo.com>
To:     Michael Turquette <mturquette@baylibre.com>,
        Qing Wang <wangqing@vivo.com>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Robert Hancock <robert.hancock@calian.com>
Date:   Thu, 13 Jan 2022 18:44:52 -0800
User-Agent: alot/0.9.1
Message-Id: <20220114024453.D9F28C36AE3@smtp.kernel.org>
Precedence: bulk

+Robert

Quoting Qing Wang (2021-10-14 23:45:28)
> coccicheck complains about the use of snprintf() in sysfs show functions.
>=20
> Fix the following coccicheck warning:
> drivers/clk/clk-si5341.c:1471: WARNING: use scnprintf or sprintf.
> drivers/clk/clk-si5341.c:1486: WARNING: use scnprintf or sprintf.
> drivers/clk/clk-si5341.c:1501: WARNING: use scnprintf or sprintf.
> drivers/clk/clk-si5341.c:1516: WARNING: use scnprintf or sprintf.
>=20
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>=20
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
>  drivers/clk/clk-si5341.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
> index 57ae183..5d62ddb 100644
> --- a/drivers/clk/clk-si5341.c
> +++ b/drivers/clk/clk-si5341.c
> @@ -1468,7 +1468,7 @@ static ssize_t input_present_show(struct device *de=
v,
>         if (res < 0)
>                 return res;
>         res =3D !(status & SI5341_STATUS_LOSREF);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(input_present);
> =20
> @@ -1483,7 +1483,7 @@ static ssize_t input_present_sticky_show(struct dev=
ice *dev,
>         if (res < 0)
>                 return res;
>         res =3D !(status & SI5341_STATUS_LOSREF);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(input_present_sticky);
> =20
> @@ -1498,7 +1498,7 @@ static ssize_t pll_locked_show(struct device *dev,
>         if (res < 0)
>                 return res;
>         res =3D !(status & SI5341_STATUS_LOL);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(pll_locked);
> =20
> @@ -1513,7 +1513,7 @@ static ssize_t pll_locked_sticky_show(struct device=
 *dev,
>         if (res < 0)
>                 return res;
>         res =3D !(status & SI5341_STATUS_LOL);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", res);
> +       return sysfs_emit(buf, "%d\n", res);
>  }
>  static DEVICE_ATTR_RO(pll_locked_sticky);
> =20
> --=20
> 2.7.4
>