Date:   Fri, 14 Jan 2022 09:12:37 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Marco Elver <elver@google.com>
Cc:     Borislav Petkov <bp@alien8.de>, Arnd Bergmann <arnd@arndb.de>,
        Boqun Feng <boqun.feng@gmail.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Will Deacon <will@kernel.org>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] generic/bitops: Always inline some more generic
 helpers
Message-ID: <YeEwdYXOjhFfuvKA@hirez.programming.kicks-ass.net>
References: <20220113155357.4706-1-bp@alien8.de>
 <CANpmjNO2mGJjb6YO0EsgjYsEuuF9sGP26Vazb2w0NZ2svevcsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANpmjNO2mGJjb6YO0EsgjYsEuuF9sGP26Vazb2w0NZ2svevcsA@mail.gmail.com>
Precedence: bulk

On Thu, Jan 13, 2022 at 05:58:57PM +0100, Marco Elver wrote:
> On Thu, 13 Jan 2022 at 16:53, Borislav Petkov <bp@alien8.de> wrote:
> >
> > From: Borislav Petkov <bp@suse.de>
> >
> > Hi all,
> >
> > a build report by the 0day robot:
> >
> >   https://lore.kernel.org/r/Yc7t934f%2Bf/mO8lj@zn.tnic
> >
> > made me look at asm and how gcc, at least, generates funky calls to the
> > *_bit() bit manipulation functions on x86 instead of inlining them into
> > the call sites as on x86 that's a single insn, in most of the cases.
> >
> > So PeterZ says the way to go is to always inline them. So here they are.
> > The fun thing is that on x86 there is even a size decrease of more than
> > a Kilobyte for a defconfig, which is nice, see patch 1.
> >
> > As always, comments and suggestions are welcome.
> >
> > Thx.
> >
> > Borislav Petkov (2):
> >   asm-generic/bitops: Always inline all bit manipulation helpers
> >   cpumask: Always inline helpers which use bit manipulation functions
> >
> >  include/asm-generic/bitops/instrumented-atomic.h | 12 ++++++------
> >  .../asm-generic/bitops/instrumented-non-atomic.h | 16 ++++++++--------
> >  include/linux/cpumask.h                          | 14 +++++++-------
> >  3 files changed, 21 insertions(+), 21 deletions(-)
> 
> Acked-by: Marco Elver <elver@google.com>
> 
> Yup, this is probably something we should have done a long time ago. :-)

Thanks, I'll go stuff it in locking/core.