Date:   Fri, 14 Jan 2022 09:38:23 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, dianders@google.com,
        Wei-Ning Huang <wnhuang@google.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Sean O'Brien <seobrien@chromium.org>
Subject: Re: [PATCH v2] HID: google: modify HID device groups of eel
In-Reply-To: <20220107091357.28960-1-xiazhengqiao@huaqin.corp-partner.google.com>
Message-ID: <nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm>
References: <20220107091357.28960-1-xiazhengqiao@huaqin.corp-partner.google.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 7 Jan 2022, Zhengqiao Xia wrote:

> If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet
> Mode Switch of eel hammer will not be detected by system. when it
> is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet
> Mode Switch successfully.
> 
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> ---
>  drivers/hid/hid-google-hammer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index 0403beb3104b..e5acd15f4a55 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
>  static const struct hid_device_id hammer_devices[] = {
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>  		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
> -	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
>  		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,

Color me confused, but anything with HID_GROUP_VIVALDI should be matched 
by hid-vivaldi driver, so what is this about?

Adding some more CCs.

Thanks,

-- 
Jiri Kosina
SUSE Labs