Subject: Re: [PATCH] locking/rwsem: drop redundant semicolon of
 down_write_nest_lock
To:     Guchun Chen <guchun.chen@amd.com>, peterz@infradead.org,
        mingo@redhat.com, will@kernel.org, longman@redhat.com,
        boqun.feng@gmail.com, linux-kernel@vger.kernel.org,
        dri-devel <dri-devel@lists.freedesktop.org>
References: <20220114083742.6219-1-guchun.chen@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <33e93f72-0d5a-b624-f58e-c35155bbda1e@amd.com>
Date:   Fri, 14 Jan 2022 09:40:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220114083742.6219-1-guchun.chen@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUdjamp1eWpTaXRGaXNsSzRPMGtjYW41dFBWOEhDdmJ5cjByWDNHRS9WME5N?=
 =?utf-8?B?aGhSOWFnclVzRldJRjB3bTBQSW93WXgydzU2SmdmYlgwL3BpaFlqWjBTeEI0?=
 =?utf-8?B?ZnlSKzZqZlI5ZVBHYVNvUytIOGFxTGdkZkcxdGZ6K3BGd0VlK1crbnY3ejhS?=
 =?utf-8?B?clIrUWxtUlViTnZ1WUVncFlFTWR5Wno2NDNNZzVVVUNHMDFrRXZHY0Z6OENa?=
 =?utf-8?B?MERZaElTVytvWjhwSnZudVVMUjZPMlVTd3hjVVZRaWtoZjJ2RlBvS0ljcHVB?=
 =?utf-8?B?QkZqU0VuTWc4L2NpeHdnNEhXMG4xZlRzWloxcUp3cEZneHNWV2ZoSTdSdk1r?=
 =?utf-8?B?YVpybzYxU1o4STBuWmorNmpWYzh3OGdteXp5SFE5aGwzazFjeGpMRjZycGor?=
 =?utf-8?B?cjdNMjBlVS9qMVVxeUsrK2tGdzYrZDVqWHFxdGd6RUpOczlZa1p1R1hXRnBH?=
 =?utf-8?B?U3hCQ1U0TUpWNjVxY2RxT2tpSU1ibEFlTkZmUzYveWhrc0xYR0Y2Mm53cnJW?=
 =?utf-8?B?NTYwRXplTHNVcGZMMXV4SzNQaDczQlR6ZHBJRkptcXUwdXg0STkyVCt6VjBQ?=
 =?utf-8?B?TllLK0VPMTdWZlg1S0FWcG5xN1U2RGROdHRrbERQOUg5Y2g4UTFNalV6M0dD?=
 =?utf-8?B?aXNxNEdDRktQb0YzSmJwd2QxdlBBQ3QrN1BPRExpdHZDeDF0MzlMQ3EzbUdB?=
 =?utf-8?B?Vk9IaWlaV3YveFA5MlJHODAyUnJZYklYK3BLQ29rVzVtWFRFcW82SHlEaDl0?=
 =?utf-8?B?S0JHaUU0Wm5SRU9zdXVhTUdhYTBTamRvVmYrcFBPUFJpdGhRVXZnTFFzTjZi?=
 =?utf-8?B?VTI4OEo3TS9LN240UFZ2am00ZzAwVUUxV1N3WlZHdjVZSFZCbkdCNXZyT3du?=
 =?utf-8?B?c0hNZDk4K3BlakZySUQ4TWtlRVdEaTJCeW1ISXBGR2hxUU9Wd2NEZ2QwWi9t?=
 =?utf-8?B?SWhxdE1pc0VUNm5rV1JXQTd2akJHdUtoMmtwQU5YRzhCZ211WkN3dGtOT1dI?=
 =?utf-8?B?UFlXQlp0dFJ4OWM5Q2lVT3lOT2NrSWN4cTQrdUljeUgwVHZqWjRUZ3kvTllm?=
 =?utf-8?B?aGhKaVpJVHBMMDhyN1Q0Y2xBOTJmWWk0M2dmQlR3Q3hUdkFOL0d5MVhndHVR?=
 =?utf-8?B?Q09pS2NxQ2RtYTRvM3hZdG9MZUxuVFM1M2kxUytodWVZS3RsR2NlR3Ewai9Z?=
 =?utf-8?B?S2J5cVp6WDdyWnhDY00yVGdqQTlVeG82RDJoTTJ6UCtTeHVIRFhBcHZEWWNR?=
 =?utf-8?B?SWowc0ZyZUpaNVcvcGQybG40ZDlwYzJLWUNhb3NIdkg2VC8zU2hEWENRRllp?=
 =?utf-8?B?OUxHbjZhRWlzMTd3cU9yZ0J5VkF5L2E2dXVLTDBYVmdNNCtheTB4UE9xbndL?=
 =?utf-8?B?L2UxSnpDNGVNbXpVYmFGb3kyWUtDTzJGd0NiLzlWYTF3TndybUZhUHNET3ZI?=
 =?utf-8?B?UWpRUTB4YjY3L0MyMEZtZ1ZpRVRhaEpWTzVMRTl6YXdYZ0dHYzRtcTZXUEVh?=
 =?utf-8?B?MEt0OFhSYmZNZ0xTalFtZlNIeDlGWFp6UFVqWjhvdmhVRmtBQnNRdnJUc1NB?=
 =?utf-8?B?NHgyNC82SVIxeFk0Zk9iblZtM2tYeUh6L1R2c2Z4SlYrNVJLQ052Wnl0MGV4?=
 =?utf-8?B?VEJsRkIxTEdFN1NJWnJqV05qRHg1Q3hJckVUaG0wUmMzbFFZVktRdjM0Mmx0?=
 =?utf-8?B?V1I5bHpPYjBrSmtsMEoxdmJRK2d3WFh2ZkcwNlFqM2FwSlQvOXZDeTdRc1Ey?=
 =?utf-8?B?eUtDRzNURWtkQUg4Z2QvRHN4WWFiU0tmZnVPZVJTaklVSy9xTjRPbmJnK0lp?=
 =?utf-8?B?b05SR1pxRENCdFhEN1E3YTAyUE1JNDE0TG9rZm40c3grRU9BUnlsL0s4Yzd3?=
 =?utf-8?B?MmF4T0loT1RKalR4QmhoT0Q0MHlPeWR6cnlvaENjUzR5ekprQmNRTTk5QmlW?=
 =?utf-8?B?ckN2cjJUR2hrUGwrOEdUNDZ4dkoyQloyclBJVlBBdkJnTS82L1RsZ2s0bEd1?=
 =?utf-8?B?bnFua09Xa0JmMlMyRzhVbXIrUk1ZMTVWdlZMejZwa3VCaUxUZDd3WXk2OUU5?=
 =?utf-8?B?STA5YXYzSDBwTFduWndpdG9NNjlQVWtlMFliT3BCTTB6Vk9VdnFxSVcrcDZW?=
 =?utf-8?Q?UhAQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd382c1f-e7e3-43d2-fca9-08d9d73998bd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 08:41:02.7987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yzjc050Olp8ukhTv66geU13VFwtE2gf4JoS37fREc+/1IMPYX5Y0r/B7Tisk6BIW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3415
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 14.01.22 um 09:37 schrieb Guchun Chen:
> Otherwise, braces are needed when using it.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

Peter any objections that we push this upstream through the drm subsystem?

Thanks,
Christian.

> ---
>   include/linux/rwsem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
> index f9348769e558..efa5c324369a 100644
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
>   do {								\
>   	typecheck(struct lockdep_map *, &(nest_lock)->dep_map);	\
>   	_down_write_nest_lock(sem, &(nest_lock)->dep_map);	\
> -} while (0);
> +} while (0)
>   
>   /*
>    * Take/release a lock when not the owner will release it.