Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74C5C433FE for ; Fri, 14 Jan 2022 09:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234157AbiANJUO (ORCPT ); Fri, 14 Jan 2022 04:20:14 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50949 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbiANJUM (ORCPT ); Fri, 14 Jan 2022 04:20:12 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CEBBF5C0184; Fri, 14 Jan 2022 04:20:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 14 Jan 2022 04:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=cxGeAwcSjcL8VU9JBG8vAUhRx6Y PVJOrfbXubDbWanA=; b=GiHP/4JAs1XrQ6axffzBCNgHu0qz4spwcBfwkQy6SpM C1J1qpWuGJbiGUZCYTD6zInKzxjxrPYMRnHQbMueQ8ccxTwMuqpXcCeO9Zlirji6 BokB3R8NkfWADVVQh8H7fd1Q2SXU/2UfRLwamdn0Kpf8vNkIi/L+OiyRsluen8wX h6HMCjwi9SkUGB3s3EDipFbRDBBDQH5BMMiIDDrhH5SeVxiEriYaAkvrJ1cb8JAk SiiH9NtlWOxU8VN5dTF2ljbK32KKNSqK29RP8BKIceG4LBHpevx9hRauAflJRjvA S82NTfmR45xtUBPBKklzf54UCGZ4lKCf0wZ4i+O5ZzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cxGeAw cSjcL8VU9JBG8vAUhRx6YPVJOrfbXubDbWanA=; b=Z1tk1s5kejmw7oqN2ssnIA SBMwLcxtBgqz7+4gIK15HuYaHbcZoouETgjpuXSLE1eQ2pUVUQFiQBNF003Tb5lU 9gJEjlOgf4FglgIXyBHaWfjm+unAE/dZd9k6rmh7hYD9RepTyZPKC0qoZco8PKIn OLqupUWnFdSHTwzS7X+HSvaNLTtY4e4TMMQ4VsZTkTeucj29AvVVWfj58DzdFtY0 lVeoQ1jgSyDNwQSKU3fLSb7vMfxUIC76kGPeWgRGTgnQwlUaKdLlweGodGA0OV1g QQrbZlB3GZz490XndfTAR5p7r/JBdopDg4DBKSVEKvdMpCGLITWpjxc3GR1qCiwA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdehgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeeutdfgjeeuudehvefgvedvtedtudelfffgffekledtffekgedukeejueevieeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Jan 2022 04:20:10 -0500 (EST) Date: Fri, 14 Jan 2022 10:20:07 +0100 From: Maxime Ripard To: Conley Lee Cc: robh@kernel.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20 support Message-ID: <20220114092007.7nf5m5cunbifmo5d@houat> References: <20220111103542.f7ilg2ugqklpztr5@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7wslry4pvqogojtw" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7wslry4pvqogojtw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jan 12, 2022 at 10:37:55AM +0800, Conley Lee wrote: > On 01/11/22 at 11:35=E4=B8=8A=E5=8D=88, Maxime Ripard wrote: > > Date: Tue, 11 Jan 2022 11:35:42 +0100 > > From: Maxime Ripard > > To: conleylee@foxmail.com > > Cc: robh@kernel.org, wens@csie.org, devicetree@vger.kernel.org, > > linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20 > > support > >=20 > > Hi, > >=20 > > On Wed, Jan 05, 2022 at 10:45:50AM +0800, conleylee@foxmail.com wrote: > > > From: conley > >=20 > > This should be your full name in the author and signed-off-by > >=20 > > > ARM dts: sun7i: Add Marsboard A20 board > > >=20 > > > This patch add support for Marsboard A20 board. > > >=20 > > > The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD > > > card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2 > > > USB2.0 OTG, USB WIFI(RTL8188EU) with antenna. > > >=20 > > > Change since v1. > > > - Spearate biddings and dts as two patches. > > > - use SPDX tag > >=20 > > And the changelog should be after the --- below > >=20 > > > Signed-off-by: conley > > > --- > > > arch/arm/boot/dts/Makefile | 1 + > > > arch/arm/boot/dts/sun7i-a20-marsboard.dts | 183 ++++++++++++++++++++= ++ > > > 2 files changed, 184 insertions(+) > > > create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts > > >=20 > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > > index 0de64f237cd8..4628a2617313 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \ > > > sun7i-a20-icnova-swac.dtb \ > > > sun7i-a20-lamobo-r1.dtb \ > > > sun7i-a20-linutronix-testbox-v2.dtb \ > > > + sun7i-a20-marsboard.dtb \ > > > sun7i-a20-m3.dtb \ > > > sun7i-a20-mk808c.dtb \ > > > sun7i-a20-olimex-som-evb.dtb \ > > > diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boo= t/dts/sun7i-a20-marsboard.dts > > > new file mode 100644 > > > index 000000000000..7ab6aa30fee6 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts > > > @@ -0,0 +1,183 @@ > > > +// SPDX-License-Identifier: LGPL-2.1+ > >=20 > > The license for DT files is usually a dual-license with GPL and MIT, > > which would be: > >=20 > > SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >=20 > > You can't link to a DT, so GPL and LGPL should be equivalent here, and > > MIT is useful for other projects (like the *BSD) that reuse the DT. > >=20 > > > +/* > > > + * Copyright 2021 Conley Lee > > > + * Conley Lee > > > + */ > > > + > > > +/dts-v1/; > > > +#include "sun7i-a20.dtsi" > > > +#include "sunxi-common-regulators.dtsi" > > > + > > > +#include > > > +#include > > > + > > > +/ { > > > + model =3D "HAOYU Electronics Marsboard A20"; > > > + compatible =3D "haoyu,a20-marsboard", "allwinner,sun7i-a20"; > >=20 > > Is there multiple boards called marsboard? > >=20 > > If not, then the compatible should be haoyu,marsboard. > >=20 > > The file name should be sun7i-a20-haoyu-marsboard too. > >=20 > > > + aliases { > > > + serial0 =3D &uart0; > > > + }; > > > + > > > + chosen { > > > + stdout-path =3D "serial0:115200n8"; > > > + }; > > > + > > > + hdmi-connector { > > > + compatible =3D "hdmi-connector"; > > > + type =3D "a"; > > > + > > > + port { > > > + hdmi_con_in: endpoint { > > > + remote-endpoint =3D <&hdmi_out_con>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&ahci { > > > + target-supply =3D <®_ahci_5v>; > > > + status =3D "okay"; > > > +}; > > > + > > > +&codec { > > > + status =3D "okay"; > > > +}; > > > + > > > +&cpu0 { > > > + cpu-supply =3D <®_dcdc2>; > > > +}; > > > + > > > +&de { > > > + status =3D "okay"; > > > +}; > > > + > > > +&ehci0 { > > > + status =3D "okay"; > > > +}; > > > + > > > +&ehci1 { > > > + status =3D "okay"; > > > +}; > > > + > > > +&gmac_mii_pins { > > > + pins =3D "PA0", "PA1", "PA2", > > > + "PA3", "PA4", "PA5", "PA6", > > > + "PA7", "PA8", "PA9", "PA10", > > > + "PA11", "PA12", "PA13", "PA14", > > > + "PA15", "PA16", "PA17"; > > > +}; > >=20 > > Why do you need that node? > > 1. There are two boards called marsboard, another one is based on > sun4i-a10. Ok > 2. About the gmac_mii_pins node: the pin PA17 is connected to PHY > as EXTERR signal on sun7i-a20-marsboard, it's different from=20 > the definetion in dtsi. The A20-Olinuxino-Micro has the same thing then, please do it like they did. Maxime --7wslry4pvqogojtw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYeFAQwAKCRDj7w1vZxhR xZpLAQDgx17qKKn50MvjPu2w1aATa9Rzu2Yicq3GzM8ucVVOmgD+IWqqfFJb3jee necOjJSqyC04y6SGC6pFW1YSRAv4tgs= =wfqu -----END PGP SIGNATURE----- --7wslry4pvqogojtw--