Date:   Fri, 14 Jan 2022 10:21:39 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Conley Lee <conleylee@foxmail.com>
Cc:     wens@csie.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20
 support
Message-ID: <20220114092139.eecdrmonsrvjuitb@houat>
References: <tencent_DC7B4D416B69D6D6789356010B5B9647C606@qq.com>
 <20220112031347.2492813-1-conleylee@foxmail.com>
 <tencent_00147CCBB6C9A0A0830DCE43F25DBC40A505@qq.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cw4mmidoewi6oeca"
Content-Disposition: inline
In-Reply-To: <tencent_00147CCBB6C9A0A0830DCE43F25DBC40A505@qq.com>
Precedence: bulk


--cw4mmidoewi6oeca
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 12, 2022 at 11:13:46AM +0800, Conley Lee wrote:
> Add sun7i-a20-haoyu-marsboard.dts to support haoyu marsboard a20 SBC

A description of the board would be nice

> Signed-off-by: Conley Lee <conleylee@foxmail.com>
> ---
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../boot/dts/sun7i-a20-haoyu-marsboard.dts    | 183 ++++++++++++++++++
>  2 files changed, 184 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
>=20
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 0de64f237cd8..5f1602d62927 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \
>  	sun7i-a20-icnova-swac.dtb \
>  	sun7i-a20-lamobo-r1.dtb \
>  	sun7i-a20-linutronix-testbox-v2.dtb \
> +	sun7i-a20-haoyu-marsboard.dtb \

This should be ordered alphabetically

>  	sun7i-a20-m3.dtb \
>  	sun7i-a20-mk808c.dtb \
>  	sun7i-a20-olimex-som-evb.dtb \
> diff --git a/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts b/arch/arm/b=
oot/dts/sun7i-a20-haoyu-marsboard.dts
> new file mode 100644
> index 000000000000..4c6c6ae0c459
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
> @@ -0,0 +1,183 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2021 Conley Lee
> + * Conley Lee <conleylee@foxmail.com>
> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	model =3D "HAOYU Electronics Marsboard A20";
> +	compatible =3D "haoyu,a20-marsboard", "allwinner,sun7i-a20";
> +
> +	aliases {
> +		serial0 =3D &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path =3D "serial0:115200n8";
> +	};
> +
> +	hdmi-connector {
> +		compatible =3D "hdmi-connector";
> +		type =3D "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint =3D <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +};
> +
> +&ahci {
> +	target-supply =3D <&reg_ahci_5v>;
> +	status =3D "okay";
> +};
> +
> +&codec {
> +	status =3D "okay";
> +};
> +
> +&cpu0 {
> +	cpu-supply =3D <&reg_dcdc2>;
> +};
> +
> +&de {
> +	status =3D "okay";
> +};
> +
> +&ehci0 {
> +	status =3D "okay";
> +};
> +
> +&ehci1 {
> +	status =3D "okay";
> +};
> +
> +&gmac_mii_pins {
> +	pins =3D "PA0", "PA1", "PA2",
> +	"PA3", "PA4", "PA5", "PA6",
> +	"PA7", "PA8", "PA9", "PA10",
> +	"PA11", "PA12", "PA13", "PA14",
> +	"PA15", "PA16", "PA17";
> +};

See my comment on v3

Maxime

--cw4mmidoewi6oeca
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYeFAowAKCRDj7w1vZxhR
xfMSAQCORSOVuXj7dX8+CrwJRPl/Es3bmoRvUwX4JnNOkiJgIQEAxEb7aQFRPKqG
nu+uMGT3V4istscivueMjZjp1DW6XA8=
=rZVi
-----END PGP SIGNATURE-----

--cw4mmidoewi6oeca--