Subject: Re: [PATCH] drm: bridge: it66121: Remove redundant check
To:     Drew Davenport <ddavenport@chromium.org>, ple@baylibre.com
Cc:     a.hajda@samsung.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220114064012.1670612-1-ddavenport@chromium.org>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <44f2e610-ab69-2c32-8c1d-a9f40aa607f0@baylibre.com>
Date:   Fri, 14 Jan 2022 11:48:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220114064012.1670612-1-ddavenport@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/01/2022 07:40, Drew Davenport wrote:
> ctx->next_bridge is checked for NULL twice in a row. The second
> conditional is redundant, so remove it.
> 
> Signed-off-by: Drew Davenport <ddavenport@chromium.org>
> ---
>  drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 06b59b422c69..69288cf894b9 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client,
>  		return -EPROBE_DEFER;
>  	}
>  
> -	if (!ctx->next_bridge)
> -		return -EPROBE_DEFER;
> -
>  	i2c_set_clientdata(client, ctx);
>  	mutex_init(&ctx->lock);
>  
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>