From:   Michael Riesch <michael.riesch@wolfvision.net>
To:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        Jacopo Mondi <jacopo@jmondi.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Daniel Scally <djrscally@gmail.com>,
        =?UTF-8?q?Niklas=20S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        Michael Riesch <michael.riesch@wolfvision.net>
Subject: [PATCH 2/2] media: v4l2-mediabus: add support for dual edge sampling
Date:   Fri, 14 Jan 2022 11:57:55 +0100
Message-Id: <20220114105755.730200-3-michael.riesch@wolfvision.net>
In-Reply-To: <20220114105755.730200-1-michael.riesch@wolfvision.net>
References: <20220114105755.730200-1-michael.riesch@wolfvision.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PTGeeIc9CvUlZQJX4Ru5P7qSqJkzJLiAUl8u+1cAbrlMHx/0GFTs3tTFV00R?=
 =?us-ascii?Q?syRl1hV5GdIK1XcdhkTa9YGiOKaKvEalq2i1R6vaiZj0/ts61IButsdYS+Gn?=
 =?us-ascii?Q?tM/hgcmpxoyr7kqta6+gjOsW6Lv2jOFZrNOcu2FzCaexlSnsE2j5/zq0b1oE?=
 =?us-ascii?Q?DONmaWkgXy0Pcs84/a6kmHQk10OvGmkPUhX/YLB5bXUU8B1KyQhLZ/cH5PBw?=
 =?us-ascii?Q?cUhE7L/0O46+h2pv795W4wtmVZ5nOZYYGcLNNyxG46mBHTufq6W9eT3JKcWT?=
 =?us-ascii?Q?77bYfc8OeQyadlcsi92lq3xQbH+6QSIUac0ll5ffWIqK1cGyBm0+codipjjc?=
 =?us-ascii?Q?G9tg80M9GaO3A5WEecjZt6xBrgQX5GxTwLaLQfmoMeyD9EDpWA411etimIaN?=
 =?us-ascii?Q?7PRQyZP1OBOnH/KUr9iTepIyAXoygZe5mdzouKk/fx+511RWo+IiU7LiYKu1?=
 =?us-ascii?Q?InmXNBqnylPw/EW5JSOX3SIjLekELlVyzLsYov6Jdxogt/mVGUXYfh6tf7Yc?=
 =?us-ascii?Q?FjzlQ+NWUpcfa16CuDhj/apdq4CmLiULsvds/nht2FEFInqvauqxy3DAUgYm?=
 =?us-ascii?Q?H9hcZxyeSDFMicE9uLGzhW88SnnBJOBDvMMP+vgQ8YpwzSYH8blqmpAwr/wh?=
 =?us-ascii?Q?zWVE9fnjwh244csEPMD9sRdoEbI/JNSfYKJNhyS2XGO2GLamxOpVhXkpppWo?=
 =?us-ascii?Q?hshNSoBZcKjOIpAyX6KlVyAxJmjQN4e1/dR7336ProsuZXMl0yM59SUmFwdW?=
 =?us-ascii?Q?cE5kc1RVvsTjbfSbGiRUyC3G1ovGrVAbNIyU+yBWc5fhZzlYGQlJRTtRKb7c?=
 =?us-ascii?Q?W0AahG4H+jY5nsCAyOVUoa+05w2x5bJuWgCu2urI9VjPgn8RolmPIMRl6fen?=
 =?us-ascii?Q?OXKL0bFknSBdg4hA0jg3QmANT5h57HYCB4vnF6+XxeTUYPeTkZNlCyD4hq7G?=
 =?us-ascii?Q?bJoBEFp/AKZuV/FOHTYlQgstOPEoIIa1QBdYLeoTeni3VU3VIAHNLu4EFui/?=
 =?us-ascii?Q?bVs77/sXy8Q4YURH5ZPjvVpwWcgZ0dT3w1o3k+ElAzbYH3lfQVqzSwtaozmG?=
 =?us-ascii?Q?xD01P3qmgy5rZRIDP4eqY4+hU2UnB7ZROVZC755M2Rv9rG7J2CKLgMyxEsv2?=
 =?us-ascii?Q?onGhxD8nsJ1ZBdufAEeH5Q0e+zkwUZZZ0qkBaZw9J0XZNp9z/tnWLEr8VWTM?=
 =?us-ascii?Q?DCisUxjDB/t4hKfwgYuPEJL8JBJjc79l4TF5NU7+aWHoKwS9rvu4mWsYwYcd?=
 =?us-ascii?Q?gCCOTbqeVtK9GslkimWlgMPTkBZ5IfsjWbVgAm2WioFNUGL7NlNvwgpm2Xmg?=
 =?us-ascii?Q?0cPXKqSAq6uSr9ARW7Xsb8W63EX7HqDhlgDfDZWIDp1ijBopEA9zD6CiCXHq?=
 =?us-ascii?Q?X7RtOwh2Li31dQd/0F117IfsJ6jT5jtX9DKsdiFdu3LG7ya6bBJOUy48XuIH?=
 =?us-ascii?Q?Rj1eH3HnYg1p7JlGnq6OIeMJVnDcgeo9aNsxgcAz4i6SKvWY/e0o2F3O8Ia0?=
 =?us-ascii?Q?yrbRtX85d85eg1OiFtfhG29hvWwCmYA5W7jg/7HXul/ZpqwNxvyr4bFZHREy?=
 =?us-ascii?Q?SL0HeE7N5/RyDuT69YXgNTpQZ/cV1vMJECygfImKtc/iXeUryCvzpbyjLoRl?=
 =?us-ascii?Q?tPHpzUD32iLIrJ8CxxHAAlCLwWKYqsg+DP6TTkXJ3M4yuSSFOS0SI1Pq371a?=
 =?us-ascii?Q?wOtokpcdNlpEo9SY8R0rYOI2bikjl7jI+R18vNo+qIrvteOQj69ITGpuESDC?=
 =?us-ascii?Q?eQs/JXkszax4ZyFZSjahxdbhLUju6zs=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: e6113499-d9ca-470d-53f9-08d9d74cc178
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 10:58:11.4573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: erJ0EFIBPGn2S6Jdem4bmpA1gMlSTT8OF2TwQN7imdY3RAwy5ciLEVuxUJ38ZJ32zVypt3x5I0fC5pWtYkQ4nBZcWAD5ublGLSwT1QmV1Js=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2282
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Some devices support sampling of the parallel data at both edges of the
interface pixel clock in order to reduce the pixel clock by two.
Add a mediabus flag that represents this feature.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 drivers/media/v4l2-core/v4l2-fwnode.c | 23 +++++++++++++++++++----
 include/media/v4l2-mediabus.h         | 17 +++++++++--------
 2 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index 00457e1e93f6..70adf6549f5b 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -296,10 +296,25 @@ v4l2_fwnode_endpoint_parse_parallel_bus(struct fwnode_handle *fwnode,
 
 	if (!fwnode_property_read_u32(fwnode, "pclk-sample", &v)) {
 		flags &= ~(V4L2_MBUS_PCLK_SAMPLE_RISING |
-			   V4L2_MBUS_PCLK_SAMPLE_FALLING);
-		flags |= v ? V4L2_MBUS_PCLK_SAMPLE_RISING :
-			V4L2_MBUS_PCLK_SAMPLE_FALLING;
-		pr_debug("pclk-sample %s\n", v ? "high" : "low");
+			   V4L2_MBUS_PCLK_SAMPLE_FALLING |
+			   V4L2_MBUS_PCLK_SAMPLE_DUALEDGE);
+		switch (v) {
+		case 0:
+			flags |= V4L2_MBUS_PCLK_SAMPLE_FALLING;
+			pr_debug("pclk-sample low\n");
+			break;
+		case 1:
+			flags |= V4L2_MBUS_PCLK_SAMPLE_RISING;
+			pr_debug("pclk-sample high\n");
+			break;
+		case 2:
+			flags |= V4L2_MBUS_PCLK_SAMPLE_DUALEDGE;
+			pr_debug("pclk-sample dual edge\n");
+			break;
+		default:
+			pr_warn("invalid argument for pclk-sample");
+			break;
+		}
 	}
 
 	if (!fwnode_property_read_u32(fwnode, "data-active", &v)) {
diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h
index 841e190aedd9..c98f956ef586 100644
--- a/include/media/v4l2-mediabus.h
+++ b/include/media/v4l2-mediabus.h
@@ -57,17 +57,18 @@
 #define V4L2_MBUS_VSYNC_ACTIVE_LOW		BIT(5)
 #define V4L2_MBUS_PCLK_SAMPLE_RISING		BIT(6)
 #define V4L2_MBUS_PCLK_SAMPLE_FALLING		BIT(7)
-#define V4L2_MBUS_DATA_ACTIVE_HIGH		BIT(8)
-#define V4L2_MBUS_DATA_ACTIVE_LOW		BIT(9)
+#define V4L2_MBUS_PCLK_SAMPLE_DUALEDGE		BIT(8)
+#define V4L2_MBUS_DATA_ACTIVE_HIGH		BIT(9)
+#define V4L2_MBUS_DATA_ACTIVE_LOW		BIT(10)
 /* FIELD = 0/1 - Field1 (odd)/Field2 (even) */
-#define V4L2_MBUS_FIELD_EVEN_HIGH		BIT(10)
+#define V4L2_MBUS_FIELD_EVEN_HIGH		BIT(11)
 /* FIELD = 1/0 - Field1 (odd)/Field2 (even) */
-#define V4L2_MBUS_FIELD_EVEN_LOW		BIT(11)
+#define V4L2_MBUS_FIELD_EVEN_LOW		BIT(12)
 /* Active state of Sync-on-green (SoG) signal, 0/1 for LOW/HIGH respectively. */
-#define V4L2_MBUS_VIDEO_SOG_ACTIVE_HIGH		BIT(12)
-#define V4L2_MBUS_VIDEO_SOG_ACTIVE_LOW		BIT(13)
-#define V4L2_MBUS_DATA_ENABLE_HIGH		BIT(14)
-#define V4L2_MBUS_DATA_ENABLE_LOW		BIT(15)
+#define V4L2_MBUS_VIDEO_SOG_ACTIVE_HIGH		BIT(13)
+#define V4L2_MBUS_VIDEO_SOG_ACTIVE_LOW		BIT(14)
+#define V4L2_MBUS_DATA_ENABLE_HIGH		BIT(15)
+#define V4L2_MBUS_DATA_ENABLE_LOW		BIT(16)
 
 /* Serial flags */
 /* CSI-2 D-PHY number of data lanes. */
-- 
2.30.2