Message-ID: <45b2b8d0-b913-20cd-62ca-e6014505632c@linux.ibm.com>
Date:   Fri, 14 Jan 2022 12:58:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: [PATCH] s390/qeth: Remove redundant 'flush_workqueue()' calls
Content-Language: en-US
To:     Xu Wang <vulab@iscas.ac.cn>, wenjia@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@linux.ibm.com,
        agordeev@linux.ibm.com
Cc:     linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220114084218.42586-1-vulab@iscas.ac.cn>
From:   Alexandra Winter <wintera@linux.ibm.com>
In-Reply-To: <20220114084218.42586-1-vulab@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14.01.22 09:42, Xu Wang wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/s390/net/qeth_l3_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 9251ad276ee8..d2f422a9a4f7 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -1961,7 +1961,6 @@ static void qeth_l3_remove_device(struct ccwgroup_device *cgdev)
>  	if (card->dev->reg_state == NETREG_REGISTERED)
>  		unregister_netdev(card->dev);
>  
> -	flush_workqueue(card->cmd_wq);
>  	destroy_workqueue(card->cmd_wq);
>  	qeth_l3_clear_ip_htable(card, 0);
>  	qeth_l3_clear_ipato_list(card);

Thanks for pointing this out!

IMO, this can go to net-next as it is not a fix, but removes redundancy.

Acked-by: Alexandra Winter <wintera@linux.ibm.com>