MIME-Version: 1.0
References: <20220113201920.3201760-1-laurent@vivier.eu> <20220113201920.3201760-4-laurent@vivier.eu>
 <CAK8P3a2QzMiga0FFVmTuefnq1OzsgyopiJN2he8043K0TRF1ng@mail.gmail.com>
 <a53e6d46-114f-7bb2-70b9-113c5f8a9c0e@vivier.eu> <CAMuHMdXN=2tjizcjA4vZ1FOSXDBNBkKH355fkfspgO9bOhp6_w@mail.gmail.com>
 <d5f59216-793a-f5cf-2ab6-e3cf3a4a855f@vivier.eu>
In-Reply-To: <d5f59216-793a-f5cf-2ab6-e3cf3a4a855f@vivier.eu>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 14 Jan 2022 13:09:39 +0100
Message-ID: <CAMuHMdWbsF8O34JpwpGba=w_dh4DcDT3_FKbE8RGtVun=iw6Og@mail.gmail.com>
Subject: Re: [PATCH v6 3/4] clocksource/drivers: Add a goldfish-timer clocksource
To:     Laurent Vivier <laurent@vivier.eu>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        John Stultz <john.stultz@linaro.org>,
        linux-rtc@vger.kernel.org,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Laurent,

On Fri, Jan 14, 2022 at 12:31 PM Laurent Vivier <laurent@vivier.eu> wrote:
> Le 14/01/2022 à 12:12, Geert Uytterhoeven a écrit :
> > On Fri, Jan 14, 2022 at 12:03 PM Laurent Vivier <laurent@vivier.eu> wrote:
> >> Le 14/01/2022 à 11:46, Arnd Bergmann a écrit :
> >>> On Thu, Jan 13, 2022 at 9:19 PM Laurent Vivier <laurent@vivier.eu> wrote:
> >>>> +static int goldfish_timer_set_oneshot(struct clock_event_device *evt)
> >>>> +{
> >>>> +       struct goldfish_timer *timerdrv = ced_to_gf(evt);
> >>>> +       void __iomem *base = timerdrv->base;
> >>>> +
> >>>> +       __raw_writel(0, base + TIMER_ALARM_HIGH);
> >>>> +       __raw_writel(0, base + TIMER_ALARM_LOW);
> >>>> +       __raw_writel(1, base + TIMER_IRQ_ENABLED);
> >>>
> >>> As mentioned elsewhere, the __raw_* accessors are not portable, please
> >>> use readl()/writel() here, or possibly ioread32_be()/iowrite32_be() for
> >>> the big-endian variant.
> >>
> >> We can't use readl()/writel() here because it's supposed to read from a little endian device, and
> >> goldfish endianness depends on the endianness of the machine.
> >>
> >> For goldfish, readl()/writel() works fine on little-endian machine but not on big-endian machine.
> >>
> >> On m68k, you have:
> >>
> >> #define readl(addr)      in_le32(addr)
> >> #define writel(val,addr) out_le32((addr),(val))
> >>
> >> and with goldfish it's wrong as the device is not little-endian, it is big-endian like the machine.
> >>
> >> same comment with ioread32_be()/iowrite32_be(): it will work on big-endian machine not on little-endian.
> >>
> >> We need an accessor that doesn't byteswap the value, that accesses it natively, and in all other
> >> parts of the kernel __raw_writel() and __raw_readl() are used.
> >
> > Hence Arnd's suggestion to define custom accessors in the Goldfish
> > RTC driver, that map to {read,write}l() on little-endian, and to
> > io{read,write}32_be() on big-endian.
> >
> > BTW, I'd go for io{read,write}32() on little endian instead, for
> > symmetry.
>
> You mean something like that:
>
> #ifdef CONFIG_CPU_BIG_ENDIAN
> #define raw_ioread32 ioread32be
> #define raw_iowrite32 iowrite32be
> #else
> #define raw_ioread32 ioread32
> #define raw_iowrite32 iowrite32
> #endif
>
> and then use raw_ioread32()/raw_iowrite32() rather than readl()/writel()?

Exactly.

You may want to use names that have less chance of conflicting in
the future, e.g. goldfish_{read,write}().

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds