Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Jan 2022 11:45:52 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>,
        Ian Rogers <irogers@google.com>
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, ak@linux.intel.com, john.garry@huawei.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf util: Fix use after free in metric__new
Message-ID: <YeGMoG2pv2+7nQFj@kernel.org>
References: <20211208171113.22089-1-jose.exposito89@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211208171113.22089-1-jose.exposito89@gmail.com>
Precedence: bulk

Em Wed, Dec 08, 2021 at 06:11:13PM +0100, Jos? Exp?sito escreveu:
> Addresses-Coverity-ID: 1494000
> Signed-off-by: Jos? Exp?sito <jose.exposito89@gmail.com>

Sorry, overlooked this one, now processing.

You forgot to add:

Fixes: b85a4d61d3022608 ("perf metric: Allow modifiers on metrics")

Ian, I'm taking this one, obvious fix.

- Arnaldo

> ---
>  tools/perf/util/metricgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index fffe02aae3ed..4d2fed3aefd1 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -209,8 +209,8 @@ static struct metric *metric__new(const struct pmu_event *pe,
>  	m->metric_name = pe->metric_name;
>  	m->modifier = modifier ? strdup(modifier) : NULL;
>  	if (modifier && !m->modifier) {
> -		free(m);
>  		expr__ctx_free(m->pctx);
> +		free(m);
>  		return NULL;
>  	}
>  	m->metric_expr = pe->metric_expr;
> -- 
> 2.25.1

-- 

- Arnaldo