Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Jan 2022 16:00:24 +0100
From:   =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>
To:     John Garry <john.garry@huawei.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ian Rogers <irogers@google.com>, peterz@infradead.org,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, ak@linux.intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf util: Fix use after free in metric__new
Message-ID: <20220114150024.GA5646@elementary>
References: <20211208171113.22089-1-jose.exposito89@gmail.com>
 <CAP-5=fUAR9uSAQGkukqafkoX+jz1fE8f-ziU5WeG59XT53jMWw@mail.gmail.com>
 <YeGNDskRtgpIFmzU@kernel.org>
 <44b8de2c-b976-a396-2363-61a014d7e71f@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <44b8de2c-b976-a396-2363-61a014d7e71f@huawei.com>
Precedence: bulk

On Fri, Jan 14, 2022 at 02:48:35PM +0000, John Garry wrote:
> On 14/01/2022 14:47, Arnaldo Carvalho de Melo wrote:
> > > > Addresses-Coverity-ID: 1494000
> > > > Signed-off-by: Jos? Exp?sito<jose.exposito89@gmail.com>
> > > Acked-by: Ian Rogers <irogers@google,com>
> > > 
> > > This can only happen in the ENOMEM case, but it is a good fix.
> > > 
> > > Fixes: b85a4d61d302 (perf metric: Allow modifiers on metrics)
> > Sorry, I missed this one_as well_, sigh...
> > 
> > - Arnaldo
> 
> 
> Isn't there a v3 out there? Not sure if you noticed...
> 
> Cheers

Yes, here is v3 including the Fixes, Acked-by and Reviewed-by tags:

https://lore.kernel.org/linux-perf-users/20220107182106.138418-1-jose.exposito89@gmail.com/