Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linuxppc-dev@lists.ozlabs.org,
        virtualization@lists.linux-foundation.org,
        iommu@lists.linux-foundation.org, Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        Eric Ren <renzhengeek@gmail.com>
Subject: Re: [RFC PATCH v3 5/8] mm: page_isolation: check specified range for unmovable pages during isolation.
Date:   Fri, 14 Jan 2022 10:14:51 -0500
Message-ID: <0A46DD38-CEB2-43BE-8ED0-71BDD8B87479@nvidia.com>
In-Reply-To: <ead90b32-da2b-4d66-f103-6fbec0937e93@redhat.com>
References: <20220105214756.91065-1-zi.yan@sent.com>
 <20220105214756.91065-6-zi.yan@sent.com>
 <ead90b32-da2b-4d66-f103-6fbec0937e93@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KwZS9TDSkabn+MDZssohHT+OVdfBroyoni3/5mgMmKMbCbzh5oboXnx9nmte?=
 =?us-ascii?Q?Xt7aGeyyzkuTqcP9IKGsKvI8mLL5wZ7VN9Tk+qC/LuI5Xd6l7J5a85wWpqig?=
 =?us-ascii?Q?sK3FW4/pIjnXRO/T0c3MN2CFme/VAl5Tr33hqAa8y1jSefStP+453/JQoG71?=
 =?us-ascii?Q?oXbW93aT3y4PmEsX/PJqEzJQbRckr/vKoKRnNmYicxUrjmMbp08cF8GVmBFo?=
 =?us-ascii?Q?+AL3zCNZGenr8lKrbzSd2dofUmpA1KjkD8E9SUAB+V8oL7RKMdu7/FmedSEX?=
 =?us-ascii?Q?wU3kRKjTyQ/k8uRGElqgSeGk2JgBH9LJMO7IFJrw6ykFC/KvnEix/KurS3FP?=
 =?us-ascii?Q?yvG56Rdpur9wAKwnlaXbKoIo28sbs8kmgQe2YKDfhMc3zd3kfIxUqdUxG0hH?=
 =?us-ascii?Q?XG6Sg6sG4pKOns43gGWiCS0ILxa3uqhPJPdQ6mkBgzxbr2y3tKbG1VMwfTzv?=
 =?us-ascii?Q?Hcz1eDnegjdBatowHv/FmW5SXjaPxABYlxG5vo/MR4la9Wu2S8uFOI+COMUS?=
 =?us-ascii?Q?EkqC72UL1I+sDUCqKJV5Sog7xvP2VLGT78Vx2B5V2U0k1Ld5q4VA387b6buV?=
 =?us-ascii?Q?xfFfLZicPCzX/XyH7JqIfy9oXZu2Qrhe4Z/aAaton0pf/qEzH5Wr0DieTTj2?=
 =?us-ascii?Q?mIQb55bhrrxEG0vl0hk0UFqu7kj8+N+2cqKBsNs7pj1pNQZozILeYfQLLjg4?=
 =?us-ascii?Q?okJMchtoy3pY6lc1e0zXSQ86nwsk4qC6RLl3fE3FRiqV00Hne4an8LbVe4YP?=
 =?us-ascii?Q?0M2LWsw5uAn0++c0wPZmwpO4HT1MYdZAM1+U1W0SGTTnRG2wT1XKwxOXB+mO?=
 =?us-ascii?Q?NJDNUCnSQsR+r2tn9dWsyxg8AsMX7H5kuEnnuPSrpV6dtVRTJn0Z66NW8mej?=
 =?us-ascii?Q?rDGT6dAbg246eoEc3gwlVctg7B0ydyqxyaZClXl98hnFSrBPyDkQGnTx1wSo?=
 =?us-ascii?Q?559fpe9kPe5fRMkaxPyScNqadpCK5NoS34/JzkeForeBWtAjk2UMbPqFqrhr?=
 =?us-ascii?Q?8PldcJD4zMcD8JSq1s5gZ/ou1jpbnwtSlLKbl0aU4bIU6cjqdZiLH0IAeZL7?=
 =?us-ascii?Q?6HKqNwTjI8QQhO2Ztn7qrWmvh4RBzFTAjLIBpHfILTRJSlSmAQU+HFJcjeRR?=
 =?us-ascii?Q?FaSPqtcAhwUpCCytOlEGltYXfJj7vc7LB9216tGffOTHI8J4iwg9Qy1RO7fD?=
 =?us-ascii?Q?ziuMvOYM2ZVk5ArIgWUdHwUVUXvA4fCPd0caXz8u9scCTqbz4H4QHyGXmqT1?=
 =?us-ascii?Q?XuaygxX/uPa4EQWO7jO/UZHiNBqxZzQOT/6EQqU2/GDdOdwSwRkqHqqeM1sg?=
 =?us-ascii?Q?jjlcQXvzOM2grHo+3TS3R/PHTn1+Li+RWNLFZ1xRTAGYjZeEtZnfH4jwCsVG?=
 =?us-ascii?Q?XjZM8JTlFUo1tjM7NUtHkaEUYMnJkRU5BkrBqrYZM93RMkN84A8XVRNP9Zpq?=
 =?us-ascii?Q?6hNua4MdeIEIHuFo9zXtSIykWYWJ7dxxdxQHaQBgT2doOx7Y5eGEaJ/VhSGq?=
 =?us-ascii?Q?FfdmxwHH5UTybI9pJuzFmVPYrc4qKuVNouddMpkM6+f8xIx+kSfDCmDkqwXh?=
 =?us-ascii?Q?0wTrORTbFZhlk6E6eQ8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d365d00f-454b-49fd-8757-08d9d7709d93
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 15:14:53.2292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t6m0gp/dPvJ/AYWD5J2H/q8GqCO1a239TQ0fMT0SsAfsO2JqLtEuHjdINM8iM1+2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3472
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_=
Content-Type: text/plain

On 14 Jan 2022, at 8:38, David Hildenbrand wrote:

> On 05.01.22 22:47, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> Enable set_migratetype_isolate() to check specified sub-range for
>> unmovable pages during isolation. Page isolation is done
>> at max(MAX_ORDER_NR_PAEGS, pageblock_nr_pages) granularity, but not all
>> pages within that granularity are intended to be isolated. For example,
>> alloc_contig_range(), which uses page isolation, allows ranges without
>> alignment. This commit makes unmovable page check only look for
>> interesting pages, so that page isolation can succeed for any
>> non-overlapping ranges.
>
> Are you handling if we start checking in the middle of a compound page
> and actually have to lookup the head to figure out if movable or not?
>

Yes. has_unmovable_pages() has that check already.


>>
>> has_unmovable_pages() is moved to mm/page_isolation.c since it is only
>> used by page isolation.
>
> Please move that into a separate patch upfront, makes this patch much
> easier to review.

Sure. Will do.

Thanks.

--
Best Regards,
Yan, Zi

--=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmHhk2sPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKHVAP+wQLmekSmaBLUZyqE6BmgXMxqAuKfHDisuju
sQ+K1TITi4vp/Fgyb3qrGtxbEsYSLoTCJ7MrO/hg/oRC4zW3UFtq9jhfX9E/jBnN
g616RnbCfmuhRzWAbegxLx7irdhlntNgvrjo/OjOwWRZtdJgF82VZyZYmjoKjCZt
kycSHdtVwVF0Ndq6KFuSct8yRXAOug2cNwCnPV/q0Dy6iQG9efK1/r8Q2TOBUcBR
QbmSrufndFopmFsbh16slJlH41SbkaChz8lHUUlmganHvRakoFxxQjg4KKcyumTG
k28DSYqGeOdhWKu/CgLkdEgB75twNx9aSJ6aFKrxxc1q4P7w9tvPUAOx4cMEZhRW
ReV8wSACAj53/oihEt6i9lRDax6Sf+JU4hZjtaQr+Vm/TRmzuttRvtP7EQiA/97d
nTazMzHcBgeXB/eSko6GqLkV8VWbvxcnAQkt7XcAQJ+pcRDktym2as3P1Tu4kSrj
V1EO6QJtqSD9RRAPWGoZG8XrHcm6O7/knkFil2a0IoFmwW0tTWcz8v2fuct07j+u
LR18iJgLhtPwJuKQ5pGcex8iLaeSaTqrX7RJlgcbN/sTuSuiTHwFxYnvPxK03dy6
Ig6pwIHSDmclpRnLFOK0TfoxruMnnj6a5yE3MkTBeG2M/xCJw8CXHAnXmxlrc+mV
llVORpAe
=emuQ
-----END PGP SIGNATURE-----

--=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_=--