Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linuxppc-dev@lists.ozlabs.org,
        virtualization@lists.linux-foundation.org,
        iommu@lists.linux-foundation.org, Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        Eric Ren <renzhengeek@gmail.com>
Subject: Re: [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size.
Date:   Fri, 14 Jan 2022 10:15:25 -0500
Message-ID: <FC7DE076-4FB5-44ED-9A57-9112136AE2AC@nvidia.com>
In-Reply-To: <60778775-b5f5-0837-092f-9911cec84854@redhat.com>
References: <20220105214756.91065-1-zi.yan@sent.com>
 <20220105214756.91065-8-zi.yan@sent.com>
 <60778775-b5f5-0837-092f-9911cec84854@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_C438F204-3693-4696-9E76-A1C6EFF005F6_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/FUHBoOzcZ59htlqJc/G+sDElTtrz8gX5pCDUP0Kmt2HAYIO72B6z+pkNVc9?=
 =?us-ascii?Q?H2WRcIN6PqT4j2/N4l5GDiN4KDrzlIzLcM5+Om1bgmetPmgjxrmdmCCSZlcS?=
 =?us-ascii?Q?QEih8q7SCMi0MZl8O9L7IfuZOsRqpNTzqi7m9BXzL6Y4uwMguyPDc2NV4apw?=
 =?us-ascii?Q?EumtDVUuUB6h/ihPU/B+BF7L2OXcI2wgm6V+xWPYtx/X+V1n9YNYcbk95M8Q?=
 =?us-ascii?Q?ItpKcySTqG1hbqzfcaxoC59ejZh2ED0mosmOZMzlUEjLJkGjyvz7PGPyS5mw?=
 =?us-ascii?Q?82Eb9AjYVCaIqqzfouZ9kRpbm+h1RqTVV5ExxbAtrjkOL/RDYjuzGdbftvWL?=
 =?us-ascii?Q?i+qXZwO/e199TlfNHV7go+aqnAfHHvt1+Ze3H9YSWYF2zhBTcJR32cGvcnju?=
 =?us-ascii?Q?FGEmHH/7zBj+NGX4LYRUJTFdhCtkiSFnyynNbxGcd1NI6a4zVGrwBm566U/7?=
 =?us-ascii?Q?j2G1yPrz9u3NX6iw0uUb3ZlJ77dAyYEmHKxCKgGpT46T9ZD7E9OzsKbPBjWu?=
 =?us-ascii?Q?3vmMclXCWjHToHX1/Pw7yeI/th/YVjKkSLKhvq8c3FP3NJ0mpte5XFnc49cy?=
 =?us-ascii?Q?k5203+Zbd8sHFlvVZ9i4VWxoiSutzVcfmozNaEbMtfpoVn7yDX9TWW47L0hl?=
 =?us-ascii?Q?m4WxPGcWVjfT+/M/7iVxfMu2u1I6emoholoEN0WurpFaEaBPx19LGAFzHm/l?=
 =?us-ascii?Q?07W+pPmLvzJ8Je9swSXIYQpCp6uaXtvXpO0YDG3sN3MUUBMlnAnSE99YHJc2?=
 =?us-ascii?Q?4G2UL4NxlQWmE5oNZctJEDqYVXya/At6hCr/pJPJOZlv/lRO/ajI9mCSUePw?=
 =?us-ascii?Q?3CUOXEkLr2cbqUefwjpUHktER6FGbIq35WymmL8wP1sg1Qzogo4mE71v8YtP?=
 =?us-ascii?Q?9ivzkDQaB/2s3vMYU5NiHwDCUy6r0/sS/Y9E7diVkMVGky9KoqxJW8bnJu66?=
 =?us-ascii?Q?RRlzwuN/zGAhJUk/bXykQsYxqxN0d/WYgAORk3p8Ga37ozGLEjhJ4PllecrE?=
 =?us-ascii?Q?sTFU0/3OPkYh+pr0VBXGNjvDNhwmDEtghTMaXkO5vCGpSdk1kEcNzScAkzS3?=
 =?us-ascii?Q?w8rPdqEXb+nb09RQnehGR7S5lyD+Ei/7MYptA8T3hIPNY5CDef+6S1HpllyW?=
 =?us-ascii?Q?BULgdcsM8AYtVXi5x0T0SnOE/2v8CLx9ZLRN6AbvDKxkiQp1fbxbXfyz43JS?=
 =?us-ascii?Q?em5dTEGZgdfpSVd9FkvCO4pWJvra3MTN83Y0hlvCDj+OX8U6bLHmtMb0Ew91?=
 =?us-ascii?Q?BiInNGx16uHkgmIfmStQz35dylggaMmZTDFWP49VOdl9ZyHnEwldRgYE3TL6?=
 =?us-ascii?Q?MfbZp79ibQvg8VyYyvavIT7z5LldCG1h+TydlF1wK01J3jpXsH/FU2MrXPAQ?=
 =?us-ascii?Q?xpXQ5Ro1wyQk3Kh8ZxhA8znNahSX+W8uebjPfCPkTV+JiCOdbN35g60tY9qv?=
 =?us-ascii?Q?Z2zYmSogTsU6TwvQYWKlZ2Ze1kY7sceYjG00jAVliXI24dKY0Qnx3ekITtqC?=
 =?us-ascii?Q?VAAj5ZgrmCr+F0/PQ0Z34ci9AqAArD/+0J5q5daS+oAet/THx0MbbxKGTMCV?=
 =?us-ascii?Q?dvb0H2uJaTOb9QZlKrY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc722e2b-0a17-4ffb-60ea-08d9d770b1f1
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 15:15:27.2737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EIGrIAwuQRBHYKoxZn8zJ6QaeR2lWQdZT9SvpqzAjh1/N28jjouGBEjHQhXz5/qU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5078
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_C438F204-3693-4696-9E76-A1C6EFF005F6_=
Content-Type: text/plain

On 14 Jan 2022, at 8:44, David Hildenbrand wrote:

> On 05.01.22 22:47, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> alloc_contig_range() now only needs to be aligned to pageblock_order,
>> drop virtio_mem size requirement that it needs to be the max of
>> pageblock_order and MAX_ORDER.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>  drivers/virtio/virtio_mem.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
>> index a6a78685cfbe..2664dc16d0f9 100644
>> --- a/drivers/virtio/virtio_mem.c
>> +++ b/drivers/virtio/virtio_mem.c
>> @@ -2481,8 +2481,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm)
>>  	 * - Is required for now for alloc_contig_range() to work reliably -
>>  	 *   it doesn't properly handle smaller granularity on ZONE_NORMAL.
>>  	 */
>
> Please also update this comment.

No problem. Thanks for pointing this out.


--
Best Regards,
Yan, Zi

--=_MailMate_C438F204-3693-4696-9E76-A1C6EFF005F6_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmHhk40PHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKSkEP/jaAvAcYFO5gI5Q7dXBn9mlVUbq0RjRXMjbq
FPo6FfBH+UZjHfjq3MrkPdlPjBOMc0Tgat5mQJRWPI4sKn2FuycNv1cy5H+jA/0+
P28LCSaYfKzBIW8BOeBtNvCeYkpKEudmzNacWH9TFkZUyB4ML9Ny3VqqNbHWDXXQ
saQ+ICJ4m1S9AfcaWI+6j8zR1JL6BKhzcb1qzvwgAbjeggd2D6IgDBESUn3FA8u6
HVCWcdyoIbaH7/mJYhRwoBY1Kce8fQBfhPwcylJqWQQDg/aWeDFYAG46x8VlX/y1
F/vrvziyB5VhSKYdYMV9Zwe2p2IP0cfJ09+zjqMLMfAey7fx8vDqr3OJ2n+AvNQ1
+wM7pLvWr/gMoHcbjan0Mve72ZjNMc/531gXzGLitfZoFMGD3L64hQbvoNb4fUJt
ulrNQWvLpRNxRSUo6EqpGeClQKyeQYyenCO/nESKTuEwLAJbtAvQ3TE0wxRcWYAW
XgsGVchFB3bzOXRlJ6lFLKvjbXeDh7Xw+lbUp5+eKeMzsdEi25ekGYNtLyRH4koC
C7xlY67JMTlnoG0LW94+QKm3PS4n4QuyLjYEvQe0j7FQGZuWlF+FxT/kIGiCG5CS
K3Tw5j3OuxDGE6Ywlw3gpJbi7zTvlnQh75zU4XWcEJg6RNxb0C9R+G2v++Fr2qdv
I+5DtVna
=xKpA
-----END PGP SIGNATURE-----

--=_MailMate_C438F204-3693-4696-9E76-A1C6EFF005F6_=--