Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Jan 2022 09:21:52 -0600
From:   Rob Herring <robh@kernel.org>
To:     Stanislav Jakubek <stano.jakubek@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: trivial-devices: fix comment indentation
Message-ID: <YeGVEMl5aKgIHZIv@robh.at.kernel.org>
References: <cover.1642080090.git.stano.jakubek@gmail.com>
 <ea7e6b645fb1c2612f14ca62471180a38d51e9f9.1642080090.git.stano.jakubek@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea7e6b645fb1c2612f14ca62471180a38d51e9f9.1642080090.git.stano.jakubek@gmail.com>
Precedence: bulk

On Thu, Jan 13, 2022 at 02:39:40PM +0100, Stanislav Jakubek wrote:
> Indent comments the same as the content they describe.
> Fixes yamllint warnings like:
> 32:13     warning  comment not indented like content  (comments-indentation)

But that's not a warning we enable or is this something new in newer 
yamllint?

In any case, a change like this can only be done at the end of the merge 
window just before rc1. Otherwise, it is merge conflict hell. I would do 
that, but I really prefer it the way it is. The reason is it makes the 
'-' stand out more and those are easy to miss in yaml. For example, 
these look the same but are a bit different:

- items:
  - const: foo

- items:
    const: foo

> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
>  .../devicetree/bindings/trivial-devices.yaml  | 314 +++++++++---------
>  1 file changed, 157 insertions(+), 157 deletions(-)