Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <037f9a23-6a90-bacb-5f9c-05f9a8be3be7@linux.intel.com>
Date:   Fri, 14 Jan 2022 15:40:40 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH][RESEND] i915: make array flex_regs static const
Content-Language: en-US
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        Colin Ian King <colin.i.king@gmail.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220112223435.949071-1-colin.i.king@gmail.com>
 <87h7a86lf8.fsf@intel.com>
From:   Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Organization: Intel Corporation UK Plc
In-Reply-To: <87h7a86lf8.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13/01/2022 09:21, Jani Nikula wrote:
> On Wed, 12 Jan 2022, Colin Ian King <colin.i.king@gmail.com> wrote:
>> Don't populate the read-only array flex_regs on the stack but
>> instead it static const. Also makes the object code a little smaller.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>
>> ---
>>
>> RESEND: Use correct e-mail address for sign-off and From: in e-mail.
> 
> There are a number of things at play here:
> 
> - Our tooling checks for certain things, such as author/signed-off-by
>    match, after applying the patch.
> 
> - You have an entry in the kernel git .mailmap.
> 
> - The git log.mailmap config default has changed from false to true.
> 
> We apply the patch, and, with the default options, git show will display
> a different author than the signed-off-by.
> 
> We should use --no-use-mailmap when examining a commit to ensure the
> commit is internally consistent, regardless of .mailmap.

Yes that sounds like the right thing to do.

In the meantime I have pushed this patch.

Regards,

Tvrtko