Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     "'Jason A. Donenfeld'" <Jason@zx2c4.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tytso@mit.edu" <tytso@mit.edu>
Subject: RE: [PATCH] random: cleanup fractional entropy shift constants
Thread-Topic: [PATCH] random: cleanup fractional entropy shift constants
Thread-Index: AQHYCVwNJeBTmh3+qEWqVcWV8TuSV6xipq1A
Date:   Fri, 14 Jan 2022 15:39:06 +0000
Message-ID: <18ec4b57aecc4fa18d8e3bb6e090af1b@AcuMS.aculab.com>
References: <20220113154413.29513-1-Jason@zx2c4.com>
 <20220114153305.98505-1-Jason@zx2c4.com>
In-Reply-To: <20220114153305.98505-1-Jason@zx2c4.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Jason A. Donenfeld
> Sent: 14 January 2022 15:33
> 
> The entropy estimator is calculated in terms of 1/8 bits, which means
> there are various constants where things are shifted by 3. Move these
> into our pool info enum with the other relevant constants, and normalize
> the name a bit, prepending a POOL_ like the rest. While we're at it,
> move an English assertion about sizes into a proper BUILD_BUG_ON so
> that the compiler can ensure this invariant.
> 
...
> -#define ENTROPY_SHIFT 3
> -#define ENTROPY_BITS() (input_pool.entropy_count >> ENTROPY_SHIFT)
..
> +	POOL_ENTROPY_SHIFT = 3,
> +#define POOL_ENTROPY_BITS() (input_pool.entropy_count >> POOL_ENTROPY_SHIFT)

The rename ought to be a different patch.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)