Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Jan 2022 13:40:18 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>,
        benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, dianders@chromium.org,
        Wei-Ning Huang <wnhuang@google.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Sean O'Brien <seobrien@chromium.org>, phoenixshen@chromium.org
Subject: Re: [PATCH v2] HID: google: modify HID device groups of eel
Message-ID: <YeHtwsmKzqhU4Fiq@google.com>
References: <20220107091357.28960-1-xiazhengqiao@huaqin.corp-partner.google.com>
 <nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm>
 <CAE-0n53M723sZ7H-f0SF=AoTrwznmTRhKPapgHe5H7Mw6bPb7Q@mail.gmail.com>
 <YeHWNtl0Or1dgadz@google.com>
 <CAE-0n51TAtifbbruKhCJ_u5xH1j0zKjWOehGQFFdCez=RubxVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE-0n51TAtifbbruKhCJ_u5xH1j0zKjWOehGQFFdCez=RubxVA@mail.gmail.com>
Precedence: bulk

On Fri, Jan 14, 2022 at 02:55:49PM -0600, Stephen Boyd wrote:
> Quoting Dmitry Torokhov (2022-01-14 11:59:50)
> > On Fri, Jan 14, 2022 at 01:25:12PM -0600, Stephen Boyd wrote:
> > >
> > > My understanding is that 'vivaldi' is mostly a keyboard layout and
> > > 'hammer' is a detachable keyboard. We want to prevent the hid-vivaldi
> > > driver from probing this particular device because the hid-vivaldi
> > > driver doesn't know about detachable keyboards. Hammer devices also
> > > support 360 degree wraparound so we know that the keyboard has been put
> > > behind the screen or that it's being used to stand up the device on a
> > > table.
> > >
> > > Given all that, I'm still confused. If we make the hid-google-hammer
> > > driver probe this device and the keyboard layout is vivaldi then we'd
> > > want the part of the vivaldi driver that exposes the
> > > function_row_physmap through sysfs. Otherwise userspace won't know how
> > > to handle the function row properly. I think we need the device to stack
> > > two drivers here. Does that happen with HID?
> >
> > As far as I know HID does not easily allow "stacking" drivers like that.
> 
> Ok.
> 
> >
> > Probably the easiest way would be to export vivaldi_feature_mapping()
> > and the show method for the physical row map and call them from the
> > hammer driver.
> >
> 
> I worry about builtin vs. modular drivers so probably ought to make some

Just make hid-hammer depend on hid-vivaldi, hid-vivaldi is tiny
otherwise.

> hid-vivaldi-common.c file that has the physmap code and then have both
> drivers call that mini-library. The 'vivaldi_data' structure would need
> to be figured out too. The hammer driver stores 'hammer_kbd_leds' in the
> hid_get_drvdata() whereas the vivaldi driver stores 'vivalid_data' so we
> can't simply call the show method for the sysfs attribute without some
> minor surgery.

Yeah, we'll need to convert them into helpers into which callers can
pass buffers.

Thanks.

-- 
Dmitry