Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220114092036.766001-1-deng.changcheng@zte.com.cn>
In-Reply-To: <20220114092036.766001-1-deng.changcheng@zte.com.cn>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 14 Jan 2022 17:14:36 -0500
Message-ID: <CADnq5_P_MOsTOoRWfe95pvJ9SR6FzfcP3Un6cy9_9WB2Nv-UxQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Replace one-element array with flexible-array member
To:     CGEL <cgel.zte@gmail.com>
Cc:     "Quan, Evan" <evan.quan@amd.com>,
        "Lazar, Lijo" <lijo.lazar@amd.com>, Dave Airlie <airlied@linux.ie>,
        Zeal Robot <zealci@zte.com.cn>,
        xinhui pan <Xinhui.Pan@amd.com>, deng.changcheng@zte.com.cn,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

On Fri, Jan 14, 2022 at 4:20 AM <cgel.zte@gmail.com> wrote:
>
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use "flexible array members" for these cases. The older
> style of one-element or zero-length arrays should no longer be used.
> Reference:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h
> index eb0f79f9c876..701aae598b58 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h
> @@ -121,7 +121,7 @@ typedef struct SMU_Task SMU_Task;
>
>  struct TOC {
>      uint8_t JobList[NUM_JOBLIST_ENTRIES];
> -    SMU_Task tasks[1];
> +    SMU_Task tasks[];
>  };
>
>  // META DATA COMMAND Definitions
> --
> 2.25.1
>