Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220114083511.18906-1-miles.chen@mediatek.com>
References: <20220114021131.1F7C9C36AEA@smtp.kernel.org> <20220114083511.18906-1-miles.chen@mediatek.com>
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     chun-jie.chen@mediatek.com, linux-arm-kernel@lists.infradead.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org, miles.chen@mediatek.com,
        mturquette@baylibre.com, wenst@chromium.org
To:     Matthias Brugger <matthias.bgg@gmail.com>,
        Miles Chen <miles.chen@mediatek.com>
Date:   Fri, 14 Jan 2022 14:19:28 -0800
User-Agent: alot/0.10
Message-Id: <20220114221930.660B5C36AE9@smtp.kernel.org>
Precedence: bulk

Quoting Miles Chen (2022-01-14 00:35:10)
> Hi,
>=20
> >Have you tried removing the modules? And then reloading them? I also see
>=20
> Thanks for the comment.
> I did not try it because we do not unload our clk modules.
> After testing I understand that the clock driver does not unregister clks=
 so=20
> we cannot remove then unload it.
>=20
> I think I have to add some unregister logic to these drivers.

Yes

>=20
> >that mtk_clk_simple_probe() doesn't actually unregister anything, it
> >just frees some allocations. Please fix this before making these
> >modules.
>=20
> You meant that mtk_clk_simple_probe() has no unregister logic in error pa=
th?
>=20

Yes