Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a89bcbae-bf8f-533a-8e72-3d39a72cf040@linux.microsoft.com>
Date:   Fri, 14 Jan 2022 14:26:36 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v1 9/9] drivers: hv: dxgkrnl: Implement DXGSYNCFILE
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, spronovo@microsoft.com
References: <cover.1641937419.git.iourit@linux.microsoft.com>
 <e04c8e820bc166d9d4fe8e388aace731bb3255b0.1641937420.git.iourit@linux.microsoft.com>
 <Yd/Xvd147eh+OWlQ@kroah.com>
From:   Iouri Tarassov <iourit@linux.microsoft.com>
In-Reply-To: <Yd/Xvd147eh+OWlQ@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/12/2022 11:41 PM, Greg KH wrote:
> On Wed, Jan 12, 2022 at 11:55:14AM -0800, Iouri Tarassov wrote:
> > Implement the LX_DXCREATESYNCFILE IOCTL (D3DKMTCreateSyncFile).
>
> Your subject line does not describe what this is doing at all, as we
> have no clue what DXGSYNCFILE is.

Hi Greg,

I do not understand this comment. The full description is:
"
     drivers: hv: dxgkrnl: Implement DXGSYNCFILE

     Implement the LX_DXCREATESYNCFILE IOCTL (D3DKMTCreateSyncFile).

     dxgsyncfile is built on top of the Linux sync_file object and
     provides a way for the user mode to synchronize with the execution
     of the device DMA packets.

     The IOCTL creates a dxgsyncfile object for the given GPU synchronization
     object and a fence value. A sync_object file descriptor is returned to
     the caller. The caller could wait for the object by using poll().
     When the GPU synchronization object is signaled on the host, the host
     sends a message to the virtual machine and the sync_file object is
     signaled.
"
Is this not enough?

Thanks
Iouri