Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Robert Hancock <robert.hancock@calian.com>,
        Baruch Siach <baruch@tkos.co.il>,
        Felipe Balbi <balbi@kernel.org>,
        Balaji Prakash J <bjagadee@codeaurora.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH 4/6] usb: dwc3: Handle fractional reference clocks
Date:   Fri, 14 Jan 2022 18:39:02 -0500
Message-Id: <20220114233904.907918-5-sean.anderson@seco.com>
In-Reply-To: <20220114233904.907918-1-sean.anderson@seco.com>
References: <20220114233904.907918-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GdPwQB/oU8gcIgn7E/h4Xw5NU56C6CtAJ0Fs9uoFecx80I7afnuTmRdwsz3a?=
 =?us-ascii?Q?f3E9J/SHPhABKThEzXZX1zIG8IQYs7TkVPjbbI7tgYWfpB6sLdx2W2Cqk/Z/?=
 =?us-ascii?Q?vR4LW1IoMc4ZGH9n4xMttTq1pdDNqx4pkXZ6uIMUzauN5e6+rqjDrolVgysn?=
 =?us-ascii?Q?yoJ/cBaUwye4ClVHIsCNZy/qmpBX8Rvo3DAYdk1ChLQJpxvtGkY5sRkBmuzK?=
 =?us-ascii?Q?lDhGjRuQKZTCsat+6DtSq+m50UF8o93na6/JHau6/Y1+jwtzMpFr9A32y8Ub?=
 =?us-ascii?Q?S/7mGlGO/wGaFMle1BIeIAR3VrTMTqF3/LntxgQJZ5buw5ISwfmrvPfpd5qE?=
 =?us-ascii?Q?RyNn68n6WKIuINh0MXnpxPU5MlSomfGRN9CGO+2HAOtZToOXarCXU56Js1fw?=
 =?us-ascii?Q?dDHjsP+pBXMfNTxjvIQfRApSsR4/q99rNfdvg9jyF9QqNfJ3WX5MS47EnWWb?=
 =?us-ascii?Q?T7o6FMaLe61yy94CCgd55rXKDyJTz2MjOJcmCXdPn6IbfKG+cTLj0pQx1F/e?=
 =?us-ascii?Q?To9e8qNY8+IEvZzBUyTkmz/ol8dDedneEuveUj+mB0NYCsDaoCiXTZ2IHqzy?=
 =?us-ascii?Q?2gWCBuNX2YqRJ6OZw8AmDBCvio1qqxkype/spSQQtyoykbc1LRUKocYeSrL5?=
 =?us-ascii?Q?nATz9PXQwhSjVf+40kJBmHncR/8F+xhoVDoonz4JS+ZxZpBei+StT4KmaP3u?=
 =?us-ascii?Q?gGbT8doK2LD2hs+OhyK5Z3afx7NQ7BlQOgT7lVVfPMSWXTWdKgidWfV0S2ua?=
 =?us-ascii?Q?85rtPMSOvUHE4m9EGASwyamtZ4nNjcC3p2Qz/92mauN/amKHlOb0fqxghlGf?=
 =?us-ascii?Q?/iYFAcq0IdsM7O/L4hjpuCNJtjDkzmmjUo2Y8NqGFkmhMf/iFWZYNOPYZaeH?=
 =?us-ascii?Q?9uaz1kBV7XFBAwDoJy5Lk+VwUzwJozfgHMVNklQbEiUDeZDw2v/OSQzUIhb1?=
 =?us-ascii?Q?lLfz4+Li3t7WdG7xiDkkSyYhk0aadALGhntECokK62cAPdQ6LmDdCZum23ok?=
 =?us-ascii?Q?Z0oHTz1TFezY5He3uTlAr+kNXKkB9nwrjYthBEMroF5Zi2Z8W6LVpPJdeilG?=
 =?us-ascii?Q?53cMBEAeyZIjQEzpFRwy2f2ALWvBblH159Kev2q5tCU+fpWwbjE8wUuI/TCr?=
 =?us-ascii?Q?NEwAzKmOeLM25d/pdcSHTbxr9sSAeYkCl8+sxscemNsJiO9xyfTj41jd1pAa?=
 =?us-ascii?Q?YOtLOIsf+nNId/PDJUatH4hM3IlInzZRBMgWChd+VbscpbH+UEGIhR7aOJF1?=
 =?us-ascii?Q?TqSbj/SOQYeHd2Q27mRG2Yomzsgg3tMqtY+G4z5ejYMDPeO88fkrGNsqIl/q?=
 =?us-ascii?Q?hnRzhts7FrWkcDQaTaeqrUCJd0Y3gwHJ/a7hCP80GFeKril1MGNIZjaQVW8b?=
 =?us-ascii?Q?HK3H/lhya5AN6mNMmrBzTpgEFkm57+O55J9Jf4+0BLvVy33VuzkgFxYg+bso?=
 =?us-ascii?Q?1Xc1+baOZBbmV4piYJ4lPsaatStbZo1LU60dw0/wEYdv7miN5kvfd8CTG7Vz?=
 =?us-ascii?Q?e6sVhZ5SGMmnwiG1U9EeQTfFBgvF9YwK4t1l6FubhnLE9TMc5i1Pj4Ry7FYP?=
 =?us-ascii?Q?22Lc90+Nn24PnpEpeVsfTyzXNTnjzIfPbibmwXf5bIPIJQJuvdM7dkheV2Ar?=
 =?us-ascii?Q?fxVQgb6VQiU5jGukTgR2fns=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7a03a77-f35d-411c-ec8b-08d9d7b719be
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 23:39:26.1971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /cFf9+CBM4d34WH7PGs45aR0j4l8lKlcoY29CxmJb8NUywxbvYf1XrnRBfsE6OL+MrAcqWNamhPIItEJHZqQFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4336
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

GUCTL.REFCLKPER can only account for clock frequencies with integer
periods. To address this, program REFCLK_FLADJ with the relative error
caused by period truncation. The formula given in the register reference
has been rearranged to allow calculation based on rate (instead of
period), and to allow for fixed-point arithmetic.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 drivers/usb/dwc3/core.c | 25 +++++++++++++++++++++++--
 drivers/usb/dwc3/core.h |  1 +
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 5214daceda86..48bb3e42cdd0 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -348,7 +348,7 @@ static void dwc3_frame_length_adjustment(struct dwc3 *dwc)
 static void dwc3_ref_clk_period(struct dwc3 *dwc)
 {
 	u32 reg;
-	unsigned long rate, period;
+	unsigned long fladj, rate, period;
 
 	if (dwc->ref_clk) {
 		rate = clk_get_rate(dwc->ref_clk);
@@ -357,16 +357,37 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc)
 		period = NSEC_PER_SEC / rate;
 	} else if (dwc->ref_clk_per) {
 		period = dwc->ref_clk_per;
+		rate = NSEC_PER_SEC / period;
 	} else {
 		return;
 	}
 
+	/*
+	 * The calculation below is
+	 *
+	 * 125000 * (NSEC_PER_SEC / (rate * period) - 1)
+	 *
+	 * but rearranged for fixed-point arithmetic.
+	 *
+	 * Note that rate * period ~= NSEC_PER_SECOND, minus the number of
+	 * nanoseconds of error caused by the truncation which happened during
+	 * the division when calculating rate or period (whichever one was
+	 * derived from the other). We first calculate the relative error, then
+	 * scale it to units of 0.08%.
+	 */
+	fladj = div64_u64(125000ULL * NSEC_PER_SEC, (u64)rate * period);
+	fladj -= 125000;
+
 	reg = dwc3_readl(dwc->regs, DWC3_GUCTL);
 	reg &= ~DWC3_GUCTL_REFCLKPER_MASK;
 	reg |=  FIELD_PREP(DWC3_GUCTL_REFCLKPER_MASK, period);
 	dwc3_writel(dwc->regs, DWC3_GUCTL, reg);
-}
 
+	reg = dwc3_readl(dwc->regs, DWC3_GFLADJ);
+	reg &= ~DWC3_GFLADJ_REFCLK_FLADJ_MASK;
+	reg |= FIELD_PREP(DWC3_GFLADJ_REFCLK_FLADJ_MASK, fladj);
+	dwc3_writel(dwc->regs, DWC3_GFLADJ, reg);
+}
 
 /**
  * dwc3_free_one_event_buffer - Frees one event buffer
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 32dfcf3a83d5..50c094af131d 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -388,6 +388,7 @@
 /* Global Frame Length Adjustment Register */
 #define DWC3_GFLADJ_30MHZ_SDBND_SEL		BIT(7)
 #define DWC3_GFLADJ_30MHZ_MASK			0x3f
+#define DWC3_GFLADJ_REFCLK_FLADJ_MASK		GENMASK(21, 8)
 
 /* Global User Control Register*/
 #define DWC3_GUCTL_REFCLKPER_MASK		0xffc00000
-- 
2.25.1