Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1cbbe637-b04b-dcea-8773-39c56cf0664d@linux.ibm.com>
Date:   Fri, 14 Jan 2022 19:31:22 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v17 06/15] s390/vfio-ap: refresh guest's APCB by filtering
 APQNs assigned to mdev
Content-Language: en-US
To:     Halil Pasic <pasic@linux.ibm.com>
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, jjherne@linux.ibm.com, freude@linux.ibm.com,
        borntraeger@de.ibm.com, cohuck@redhat.com, mjrosato@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com,
        fiuczy@linux.ibm.com
References: <20211021152332.70455-1-akrowiak@linux.ibm.com>
 <20211021152332.70455-7-akrowiak@linux.ibm.com>
 <20211227095301.34a91ca4.pasic@linux.ibm.com>
 <831f8897-b7cd-8240-c607-be3a106bad5c@linux.ibm.com>
 <20220112125217.108e0fba.pasic@linux.ibm.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
In-Reply-To: <20220112125217.108e0fba.pasic@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/12/22 06:52, Halil Pasic wrote:
> On Tue, 11 Jan 2022 16:19:06 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>>> Also we could probably do the filtering incrementally. In a sense that
>>> at a time only so much changes, and we know that the invariant was
>>> preserved without that change. But that would probably end up trading
>>> complexity for cycles. I will trust your judgment and your tests on this
>>> matter.
>> I am not entirely clear on what you are suggesting. I think you are
>> suggesting that there may not be a need to look at every APQN
>> assigned to the mdev when an adapter or domain is assigned or
>> unassigned or a queue is probed or removed. Maybe you can clarify
>> what you are suggesting here.
> Exactly. For example if we have the following assigned
> adapters:
> 1, 2, 3
> domains:
> 1, 2, 3
> and the operation we are trying to perform is assign domain 4, then it
> is sufficient to have a look at the queues with the APQNs (1,4), (2,4)
> and (3, 4). We don't have to examine all the 14 queues.
>
> When an unassign dapter is performed, there is no need to do the
> re-filtering, because there is nothing that can pop-back or go away. And
> on unassign domain is performed, then all we care about are the queues
> of that domain on the filtered adapters.
>
> Similarly if after that successful assign the queue (3,4) gets removed
> (from vfio_ap) and then added back again and probed, we only have to
> look at the queues (3, 1), (3, 2), (3, 3).
>
> But I'm OK with the current design of this. It is certainly conceptually
> simpler to say we have a master-copy and we filter that master-copy based
> on the very same rules every time something changes. I'm really fine
> either way as log as it works well. :D
>
> Regards,
> Halil

I spent a day messing with this and was able to make it work, so
the next implementation will incorporate your idea here.