Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1423410pxb; Sat, 15 Jan 2022 11:42:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxeWBCFlBdMNoU8w2EOqMOltvpsStlWHZipPsZlGw81QpUi9zV7+BcRtfmQMJvAfaUUsBB5 X-Received: by 2002:a05:6402:438f:: with SMTP id o15mr2289971edc.116.1642275749509; Sat, 15 Jan 2022 11:42:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642275749; cv=none; d=google.com; s=arc-20160816; b=iIp+qidv/JvRTZTnLnIT9C2QHGYBDpegONKNnw9jDxFOX+vbE7FqMKDG/NqgW0LRr3 wpw6F6j2NDK4g+pzdsgriEyNy8JmUU1pRUMGzVKlt/RysirL9C6yn+RgAbNxeDLZ/cjF uhMWaaQszTFX0W4i5Wf2UfPQ3KVE76kHAArAi1BiZuDRjKD2Zo2wNPy3MU/akHgAEshQ VfyKuFTlnHwoYPFRvMVFsQe83ubvKI7zyBbaVbpbmDDaXfYUNSgmlF7KAdBZhRH4Jm9V st3P7iKAsp2ggZqM8E0IY+s92fu8ILw9cB7xC/gzfr2Vp+U8Oemnf6jNaj8lL9dwrXnf Q1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=smtWeg/4dSgmP5QEzTaF/crsbFBa+KmvCdKVL/1R9qqrDqelzgnR7Q0yvhTwvdcwCJ 1zaRACbUfdUmlJMSVcqWXgPOtC3PIc0mvXc5j9M9j0n8LIDBq287upS6Sy2L/h2XVC03 9YtIcmZhQHlRIe5TM5grJqzOzDSPcv2ve92j6c4l5ModQ0KONb5CwolyOuieM+iw4O3j W0J2i3K8mue5jKQTJ1krFjZMPEbfgNRxBdFP2xQshZAT3XXp7B1jjhbEiL/+bkvP4aXp 6bRnYH5xSmPc4zIibr/kUIpMUypXIGPCAof+Mbjl4PsufviydgcKbp4v5Q4eyAsufmyN ZlZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=EmUyNC5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r4si4719595eja.76.2022.01.15.11.41.51; Sat, 15 Jan 2022 11:42:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=EmUyNC5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232645AbiAOHuf (ORCPT + 99 others); Sat, 15 Jan 2022 02:50:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbiAOHue (ORCPT ); Sat, 15 Jan 2022 02:50:34 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B15C06161C for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id s22so15554081oie.10 for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=EmUyNC5+fyl6EfcWg7V5NP/+/kTDIH/EdOvuowOUADAQekSeyTVMo2Pw+R7MGnNyr3 5F8QHuI+3uuwmjE0hhIplcSf2WL7/QNRQcOV1244KFMSs7KyWUA1l2Wf6ku/ze8CULMO JrK0FD1KD6O13Y02WDkLJ8qPwwJwBY8Rk79Pk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=xDP/yuZX26Y665G0oqV7Il65yVuQQlCegwAzW56SEy+SDEXG7Ep9BOijo19PN0XaKo K7peMnEG47AcoN8vXcNibzDqq9n+lLI1YnlgfDfg/1DIdFdHcixhXDZtl1p/almNE+dG uMVPvtyXzyl/85El8Pgnx6iiaJNNcrugUZrlU9sgna602LpwEb/yTbTG3DZHntKV3J8A sLW8BvufOmnoB/Z/EL1w1dz0qyWKJSysxxpVnS9wKOI3CYRevHTSaBpdWH6c9dsT7l4W lIA9Kw/fD/AwvvZIrE2HIU6FFsH82XwM0o/DWAmb6ULd4C1HT7IdEmyetNY55mDmch01 wxBQ== X-Gm-Message-State: AOAM531gH2u8xtOt2PgmlnmigXTlslqw1MpzSufimdJuypUgwvL+NGWh tzHVYDCqH7n6ZZWxePc1d2L6Q8t4Us6bnZCn/307w+GnLX8= X-Received: by 2002:aca:a953:: with SMTP id s80mr15972957oie.164.1642233032027; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Jan 2022 01:50:31 -0600 MIME-Version: 1.0 In-Reply-To: References: <20220106214556.2461363-1-swboyd@chromium.org> <20220106214556.2461363-26-swboyd@chromium.org> <1a3b368eb891ca55c33265397cffab0b9f128737.camel@mediatek.com> <69a10908622512c60790f97942731a8ab989b727.camel@mediatek.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Sat, 15 Jan 2022 01:50:31 -0600 Message-ID: Subject: Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver To: Yong Wu Cc: Krzysztof Kozlowski , Greg Kroah-Hartman , Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Joerg Roedel , Will Deacon , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan , linux-mediatek@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device isn't ready for runtime PM until the component bind function > > is > > called then runtime PM shouldn't be enabled on the component device. > > Anyway, We should update the SMI driver for this case. I prepare a > patch into this patchset or I send it independently? which way is > better? I can roll it into this patch. It needs to be combined otherwise it breaks the bisectability of the series.