Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 15 Jan 2022 13:26:18 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>
Cc:     Stephen Boyd <sboyd@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Vladimir Vid <vladimir.vid@sartura.hr>,
        linux-clk@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for
 marvell,armada-3700-uart-clock
Message-ID: <20220115122618.plhiqnjh2755bv5h@pali>
References: <20210930095838.28145-1-pali@kernel.org>
 <20210930095838.28145-4-pali@kernel.org>
 <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com>
 <20211015090937.gnt66hgugrhwnkei@pali>
 <20211015093701.pfvkighxsndj4ujg@pali>
 <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com>
 <20211016064210.7ahqfqcvf66wtt66@pali>
 <20220115080213.0CCAFC36AE3@smtp.kernel.org>
 <20220115115018.he4hnnhlvrb6kann@pali>
 <20220115130509.4a240730@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220115130509.4a240730@thinkpad>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Saturday 15 January 2022 13:05:09 Marek Behún wrote:
> On Sat, 15 Jan 2022 12:50:18 +0100
> Pali Rohár <pali@kernel.org> wrote:
> 
> > On Saturday 15 January 2022 00:02:11 Stephen Boyd wrote:
> > > Quoting Pali Rohár (2021-10-15 23:42:10)  
> > > > 
> > > > If I was designing this driver and DTS bindings I would have choose
> > > > something like this:
> > > > 
> > > > uart@0x12000 {  
> > > 
> > > Drop the 0x
> > >   
> > > >     reg = <0x12000 0x18>, <0x12200 0x30>;
> > > >     clock-controller {
> > > >         ...
> > > >     };  
> > > 
> > > Drop this node and put whatever properties are inside into the parent
> > > node.
> > >   
> > > >     serial1 {
> > > >         ...
> > > >         status = "disabled";
> > > >     };
> > > >     serial2 {
> > > >         ...
> > > >         status = "disabled";
> > > >     };
> > > > };
> > > > 
> > > > Meaning that 0x12000 node would be 3 subnodes and all registers would be
> > > > defined in top level nodes and would be handled by one driver.
> > > > 
> > > > This is really how hardware block looks like. But it is not backward
> > > > compatible...  
> > > 
> > > Sounds good to me. I presume we need the serial child nodes so we can
> > > reference them from the stdout-path?  
> > 
> > Yes, exactly, separate nodes for serial1 and serial2 are still required.
> > 
> > But dropping clock controller is not possible as for higher baudrates we
> > need to use and configure uart clock controller. Without it we just get
> > comparable feature support which is already present in driver.
> 
> What Stephen means is making clock controller out of the uart node
> directly. No need to add separate subnode just for clock controller.

This is already implemented in v7 patch series. Clock controller is
already outside of uart nodes.