Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220115023430.4659-1-slark_xiao@163.com>
In-Reply-To: <20220115023430.4659-1-slark_xiao@163.com>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Sat, 15 Jan 2022 15:18:06 +0100
Message-ID: <CAMZdPi8uc+qHJR_OaWu_12oT1VtVE6TY=nAmfSF9h+f9hpXrcQ@mail.gmail.com>
Subject: Re: [PATCH net] net: wwan: Fix MRU mismatch issue which may lead to
 data connection lost
To:     Slark Xiao <slark_xiao@163.com>
Cc:     Shujun Wang <wsj20369@163.com>, davem@davemloft.net,
        johannes@sipsolutions.net, kuba@kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        ryazanov.s.a@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le sam. 15 janv. 2022 =C3=A0 03:35, Slark Xiao <slark_xiao@163.com> a =C3=
=A9crit :
>
> In pci_generic.c there is a 'mru_default' in struct mhi_pci_dev_info.
> This value shall be used for whole mhi if it's given a value for a specif=
ic product.
> But in function mhi_net_rx_refill_work(), it's still using hard code valu=
e MHI_DEFAULT_MRU.
> 'mru_default' shall have higher priority than MHI_DEFAULT_MRU.
> And after checking, this change could help fix a data connection lost iss=
ue.
>
> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interfa=
ce MRU")
> Signed-off-by: Shujun Wang <wsj20369@163.com>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>