Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1737689pxb; Sat, 15 Jan 2022 22:46:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJziUXGpv2fGQn0BT+J1hbwixy4WYjFTuMzHHCsOsG9vtyTrdqMZyIORD6JxvCQVbL5PQZ5k X-Received: by 2002:aa7:8f01:0:b0:4bf:f7b7:c387 with SMTP id x1-20020aa78f01000000b004bff7b7c387mr16152717pfr.54.1642315576598; Sat, 15 Jan 2022 22:46:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642315576; cv=none; d=google.com; s=arc-20160816; b=U1nf4Yo5Z3brDDfuo9lnzULFc8kvA6mJqpEOOBkmsrLYQEVT3IGLYHg2YnEuH6buF2 dZdpHQwi46JYdWHHFvmMi09WyAPlbQwbXGJJkdpxflWTn+veqthKylaEX8W+unXVvksq fveLJvAOaJK2U9IjIGmc5ssVxxtfHikfwZ3HDY+e71dS5v1Z/o5hpy7jw/QOTLjpdNFO M8i0nk7f3lwlnRcmZ2TOnj9UHynKd1LzKRd82D3PPJw8Zo88xS+xOtv8chrh15gJ+HAt VcHzVM1NLgIi2Co7ukqgMPRhU5YWTnmWM8i7Yfe1dk16fVAJntxyH+jjVAU5PjiyGHyM EIsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Ncd5IZKvHPrrlUNsXIMwKnuqz7gtjvAHZ3BqHWFsgGI=; b=ESKZEGfrfipjQJBUzP9f54cC339h4yVfLYBbll4FE17pNTU0mV70oesmGpuiqqHKJj uABpY92xgPrcNpcJPj/fI3U+2BNUPG5iRILPyAoa0hyQYmKxn14hsJaqh1BvvSVMWVCU OQ6vNta3RuvrDqBIyfoYhFQOZCZ6iGFok9gaFdPc8ggrXA3FlUzizRD89/9YgkiH1Kl9 KLHwZ6dxYh5pSuNTR6k50NY5o3wE//Y0j/acM0JGG4k0AlkfYi5srXBvgIc3Sen1mrz7 o1pi5Z7Ou8suZ4fjRAIsKaU6PuLBUdXa7GwbfPH2HCM8sy0XdMR7+X2ImoTL2Cm7S2iN YWyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZKMtG2g6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si14317254pjl.100.2022.01.15.22.46.05; Sat, 15 Jan 2022 22:46:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZKMtG2g6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232632AbiAOOUQ (ORCPT + 99 others); Sat, 15 Jan 2022 09:20:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbiAOOUO (ORCPT ); Sat, 15 Jan 2022 09:20:14 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B825C06161C for ; Sat, 15 Jan 2022 06:20:14 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id y16-20020a17090a6c9000b001b13ffaa625so25087527pjj.2 for ; Sat, 15 Jan 2022 06:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ncd5IZKvHPrrlUNsXIMwKnuqz7gtjvAHZ3BqHWFsgGI=; b=ZKMtG2g6ZqDQnOLci87+dJirsvLkyJiJNPqsvE/eHqAEKvqrcf2pU3pLmhyd5DENec LIjxASold+k6sF/b8C07/LsOCcb3b1AVmkvQVEoc4FljwSkSN4/iLdIV5GSR4DSDU3E2 8B8UYT8eYwOrl4nimmcBKp6h8ONFQrp2AykzmFpUJAzQ7RQwin789tojlVvNKkMMNQua GYnPlKP3nKzltcZ6E1RMtYBVEGimI38+kNSVMMqYo6RZBGucKjfvD7gtjg8Pcx9n3ZHp +Ydd7vrVJ1hplgSYAKTU7PgROGJPruhDkDVGKgsiQpa/qLz0Bs5in5clcKMTbfialtft PCow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ncd5IZKvHPrrlUNsXIMwKnuqz7gtjvAHZ3BqHWFsgGI=; b=sJe3w1YAZPE/a4eWMCD29AdhHIXWgWYtQ03plC9uHQ2UsH+tWGQYSsl5Yox9457npo DSTD4qqiFf2XbRCQUPGnhqzTrkt9QqR2QepFbFW9/fOWQO655qBKqjrH/hZu2BJBCzyI 0BcBdo8EiLt0lNaRrfdA3eIJ1eTinqIsDZbiMLdCwbx+hEbrhj7HeX2tUBdA1TIg+6pw Gn79YS2wwwfC2vYm/kkgNCg9rwA3fc8o63VGHr+VkTMALXtneZxtkrEFBns/yBj2wedj sUp70oTFWRC+LY6rULVty2VQqK0A3ePS49OB/H3s7E1Hu3Vy9Uxl5sXgiUwK++sj8Sxa XyuQ== X-Gm-Message-State: AOAM531A8Ka+2GukVLggcJeCRHCZ58O10TBm7mjKyRfe1Oifwfnot5h7 ja+y1QxVzA0yLdN9gwRdeoGYXripq9BxIPmwCcJtiw== X-Received: by 2002:a17:902:e309:b0:14a:3072:8d1d with SMTP id q9-20020a170902e30900b0014a30728d1dmr14172928plc.6.1642256413521; Sat, 15 Jan 2022 06:20:13 -0800 (PST) MIME-Version: 1.0 References: <20220115023430.4659-1-slark_xiao@163.com> In-Reply-To: <20220115023430.4659-1-slark_xiao@163.com> From: Loic Poulain Date: Sat, 15 Jan 2022 15:18:06 +0100 Message-ID: Subject: Re: [PATCH net] net: wwan: Fix MRU mismatch issue which may lead to data connection lost To: Slark Xiao Cc: Shujun Wang , davem@davemloft.net, johannes@sipsolutions.net, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ryazanov.s.a@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le sam. 15 janv. 2022 =C3=A0 03:35, Slark Xiao a =C3= =A9crit : > > In pci_generic.c there is a 'mru_default' in struct mhi_pci_dev_info. > This value shall be used for whole mhi if it's given a value for a specif= ic product. > But in function mhi_net_rx_refill_work(), it's still using hard code valu= e MHI_DEFAULT_MRU. > 'mru_default' shall have higher priority than MHI_DEFAULT_MRU. > And after checking, this change could help fix a data connection lost iss= ue. > > Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interfa= ce MRU") > Signed-off-by: Shujun Wang > Signed-off-by: Slark Xiao > --- Reviewed-by: Loic Poulain