Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1737697pxb; Sat, 15 Jan 2022 22:46:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJz16F4ZBo3XqWfmrfrVijrxGgSUmqc8Hvnn5so6kGo3wgyxItS5RnPOqmfMup/pQdnhmzyh X-Received: by 2002:a17:903:32c8:b0:14a:8776:c89b with SMTP id i8-20020a17090332c800b0014a8776c89bmr13475123plr.68.1642315577944; Sat, 15 Jan 2022 22:46:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642315577; cv=none; d=google.com; s=arc-20160816; b=umiZPhG5o3xTFY+Ckxaqc/NiF4o4lgSEKm6+Mfe88LTZDbfS+8h2aAtm7CWk+SysFF BzmX5LQs434VTBNFcoO8JCiqloV+CmtP0VaGINyPioWDnBcT+qkxMZzt+p2XQwtzi/OY CyE+2EFbIE30SFxO0YOMA/exZPEVMMHkRAO5yk9RlStiCg36s3IIZkBZWXqtdSBeFujn 8chzitq7iCV1Lq4Gugf33zgPzzo/Z4NWoYWxxTN/VbvdFNHw2WCqgMP5cIIe9DbuXJGO k6qDr3JKLeVtwRtDRzDiSdfPR+vg6KZ8kFtOQ7+Vl2GYWU1U8DOfCy6Fek6C/BdAOLsy DY9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=tGn6hfKYHs9cudl9unoO6x2q6NhmyB30/Z4KP2jIX7g=; b=OT/4VeZ0sBokd6S/jx9HIhWMeBbIgkMZJdl7JVUchmYmjbfHUSwUM3CCXTMjyv5pGg yzP8k1qJiUKdej9KL9SRBwAjJsB/rUcUXa5KCtJFO8z2aUjndjLrdG/WlAKbUoPvNuBB Lk5M8+4OpkEqUGOw1+XQ4jIZBhqFDnEK6ywMKD/vMRjieQr7yWIOk42izHu9jlnmvIEv F0vVUQyjpdJpngTQOlVN2zFc/yOEpF6NGMD81TgQ/Mb8a1TP6iGS9mr4xIU/GF6EGu+y 3hg6OR/Qh3e3tlnJDNriyP/1EvNJNkT8CTUrhtrfl0bKeh64nmX9GxwP0hKxEirOnxYl 6RKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si10977840pga.369.2022.01.15.22.46.06; Sat, 15 Jan 2022 22:46:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232797AbiAOOjm (ORCPT + 99 others); Sat, 15 Jan 2022 09:39:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbiAOOjl (ORCPT ); Sat, 15 Jan 2022 09:39:41 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A2FC061574; Sat, 15 Jan 2022 06:39:40 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1n8kDK-00065G-2Z; Sat, 15 Jan 2022 15:39:30 +0100 Date: Sat, 15 Jan 2022 15:39:30 +0100 From: Florian Westphal To: Kevin Mitchell Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY Message-ID: <20220115143930.GA23292@breakpoint.cc> References: <20220115040050.187972-1-kevmitch@arista.com> <20220115040050.187972-2-kevmitch@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220115040050.187972-2-kevmitch@arista.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kevin Mitchell wrote: > The udp_error function verifies the checksum of incoming UDP packets if > one is set. This has the desirable side effect of setting skb->ip_summed > to CHECKSUM_COMPLETE, signalling that this verification need not be > repeated further up the stack. Acked-by: Florian Westphal