Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220114105620.GK18506@ediswmail.ad.cirrus.com> <20220114111800.GL18506@ediswmail.ad.cirrus.com>
In-Reply-To: <20220114111800.GL18506@ediswmail.ad.cirrus.com>
From:   Rob Herring <robh@kernel.org>
Date:   Sat, 15 Jan 2022 09:55:23 -0600
Message-ID: <CAL_JsqKWMLi69kXp0fcdqLD039eSPwi=NPkPpOWKy=va1+YXow@mail.gmail.com>
Subject: Re: ChipIdea USB regression
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     Peter Chen <peter.chen@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux USB List <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Tony Lindgren <tony@atomide.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

+Arnd, Tony

On Fri, Jan 14, 2022 at 5:18 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> > Hi guys,
> >
> > My Zynq based board stopped booting today, a bisect points to this
> > patch:
> >
> > commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
> >
> > It looks like it gets stuck in some sort of boot loop of doom:
>
> Ok so poking that a little more, I think I can see what happens,
> the USB DT node looks like this:
>
> usb0: usb@e0002000 {
>         compatible = "xlnx,zynq-usb-2.20a", "chipidea,usb2";
>         status = "disabled";
>         clocks = <&clkc 28>;
>         interrupt-parent = <&intc>;
>         interrupts = <0 21 4>;
>         reg = <0xe0002000 0x1000>;
>         phy_type = "ulpi";
> };
>
> &usb0 {
>         status = "okay";
>
>         dr_mode = "host";
>         usb-phy = <&usb_phy0>;
> };
>
> So when that patch copies the DT node to the new platform device
> in ci_hdrc_add_device it copies the compatible stuff as well as
> the IRQ stuff it was targeting, this presumably causes the kernel
> to bind a new copy of the driver to that new device, which probes
> and calls ci_hdrc_add_device again repeating the process until
> it dies.
>
> Kinda looks to me like the best solution might just be to revert
> the patch, I am not sure I see how that copy of the DT is supposed
> to work?

It's not copying the DT, but yes AFAICT it does match and bind the
child device on the parent driver using the compatible match instead
of matching on driver name. I think we can use the of_reuse_node flag
to avoid this in the match, but that needs some more investigation.

Rob