Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <db86e6b1-d6f7-3f57-246b-d7f8c882e933@vivier.eu>
Date:   Sat, 15 Jan 2022 20:47:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v8 4/4] m68k: introduce a virtual m68k machine
Content-Language: fr
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        linux-rtc@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>
References: <20220115193245.3777833-1-laurent@vivier.eu>
 <20220115193245.3777833-5-laurent@vivier.eu>
 <CAMuHMdXBrPM5Zw+wtM3gi6k5n-i_OoWs_eZff27458hqepZV7A@mail.gmail.com>
From:   Laurent Vivier <laurent@vivier.eu>
In-Reply-To: <CAMuHMdXBrPM5Zw+wtM3gi6k5n-i_OoWs_eZff27458hqepZV7A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 15/01/2022 à 20:41, Geert Uytterhoeven a écrit :
> Hi Laurent,
> 
> On Sat, Jan 15, 2022 at 8:33 PM Laurent Vivier <laurent@vivier.eu> wrote:
>> This machine allows to have up to 3.2 GiB and 128 Virtio devices.
>>
>> It is based on android goldfish devices.
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> 
> Thanks for your patch (the new versions keep on coming quickly).
> 
>> --- /dev/null
>> +++ b/arch/m68k/virt/platform.c
> 
>> +static int __init virt_platform_init(void)
>> +{
>> +       const struct resource goldfish_tty_res[] = {
>> +               DEFINE_RES_MEM(virt_bi_data.tty.mmio, 1),
>> +               DEFINE_RES_IRQ(virt_bi_data.tty.irq),
>> +       };
>> +       /* this is the second gf-rtc, the first one is used by the scheduler */
>> +       const struct resource goldfish_rtc_res[] = {
>> +               DEFINE_RES_MEM(virt_bi_data.rtc.mmio + 0x1000, 0x1000),
>> +               DEFINE_RES_IRQ(virt_bi_data.rtc.irq + 1),
>> +       };
>> +       extern unsigned long min_low_pfn;
> 
> checkpatch keeps on complaining.
> #include <linux/memblock.h> instead?

oh, yes, I didn't see it was defined here. Thank you.

I've updated my patch, the change will be in the next version.

Thanks,
Laurent