Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2053824pxb; Sun, 16 Jan 2022 08:24:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCpL2GqY2SacHcQ9Nja3+waPFj8VFtHAnHQCzgmN3IKpvvstgl95lGo45Qhz0ApPX++xlI X-Received: by 2002:a17:90b:1b0b:: with SMTP id nu11mr12648182pjb.143.1642350251600; Sun, 16 Jan 2022 08:24:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642350251; cv=none; d=google.com; s=arc-20160816; b=m8Iflo/vakDAjsnqd6TMxx7aWFoQMz+onp+Vy4JZQ838Dr9gnuaXgmY8omvdgfaMRx Vh0qXIxGBTrQjRutaKvT9E3Dk2fj8dCIsk26jlLTUf+TUZ/7u4JDaotl60Uhkb77ZJuU 9gt4P/5fvn1S/K6DOB69Crf25In4ZX66VqhmHd1PBfxr1I1MPmj4cyDFYZS4u0j7LHiv aQBR5R1NxEXph69lXs6+Mnu/zqvQnBugib8b0b/GeLttRY7B3OeGnTHn/bCqDXSWCntc IZAcKg/vmkt9l7Fx3mUZJCZsqSqqv1uxxMShGyNmXCH7Jpc6VSRii3kE3cmN8XYyy7/n quig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=w75my6N+lE9Tb7Xrd/3B5AqGyYJg6q7bwJts0m1eHAM=; b=Ez7V0a5kBbC1EIjRJI8MrEpyAfzROJVDLYjAA4EF4cY16tqvbXowUhAwfihixtXEAI x/tX7EoJwaKBmxoOKEleGMES7/d5u0v/7KRufd+MzlkdrfYx0eaJ1gq9MOFyDMXi3eNh XxOZ1zZCny5epQJE9vF/eAue6iyFNleX55fh4wBtoigiEn26sxDV9EW5Pn8HCyxU45Zl bGtecdychmnWR63yo1wATEAWGW6jlJ4Nq2bvSRwbVHirQx3E+p/riZfU8Tuf5dKM8oSN wW630RrQwpYhHDzlCVdz4eNIGfjh196d+1mEHKM351ORJS18sArawjGxJlOzbF32/PKw DtUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HULieHlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si7396606plg.151.2022.01.16.08.23.59; Sun, 16 Jan 2022 08:24:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HULieHlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233903AbiAOXpV (ORCPT + 99 others); Sat, 15 Jan 2022 18:45:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233894AbiAOXpU (ORCPT ); Sat, 15 Jan 2022 18:45:20 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6178CC061574 for ; Sat, 15 Jan 2022 15:45:20 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id c71so48925802edf.6 for ; Sat, 15 Jan 2022 15:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w75my6N+lE9Tb7Xrd/3B5AqGyYJg6q7bwJts0m1eHAM=; b=HULieHlYiwuUrdzEf/a41YN5yHintRqwUa+1XNEXIwjwf+O7x7SO8+/0ejBJiMkLRv Qa7gt8IC33b3dOj97R4TZthJuecJMwdGbrnLHhSzMwjJ2yX4rrx3FJHeMkJG6vyzGCWw wj7bVt2ssWFUwm8gHkV6o07eNmrWKxsBXpSgTZFrTXKQrElgqaCHytBXy3GhHHXbPlis GB1n0zQrJQZqdM61P+Fc4cFNJ0D+yym7BaFwavjAtR9ZHs6dHASEs9H6vQ3XTkRkXNo+ e9tC5AhoOCXa7771/23ATjXEEvLPGKi0FYPuiTxTC3YYqRxGwsqqiAvOoRYfd47cwwYO Morw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=w75my6N+lE9Tb7Xrd/3B5AqGyYJg6q7bwJts0m1eHAM=; b=AiVOmYTtTWWeDsHu4iFx97l4eJp6cZ3BB6pg6EiTsMy3bRH95FPtGC0Aku3l/d8/pk MBaEtw+ARd9BEIiYf00q7sw/2ctap1Uypp+DKoW1TmAckNvo+jCTO7gOtu3ng1wUT4IU XYfRqiYfqeEU8ob0nLukuXmYbNBUulDbEMPFHx0Yk2UJvngP49hI7Dd8hVJUgdyHH5/5 ROPVBoXg+BBIthWHxwJ53xxS36t4ktT0/K3b8pdAiXc1tysCaYVAVzFnqDnumfI+jCyS e07q4Gk7Lwql1mL1RchkFhhdO9MrpiJ1+0jvXet6ZtxPA1IjjIsv8SShJsUote9CL6ij qLQg== X-Gm-Message-State: AOAM533B4jNIrXuQaYkKBVUg0ZC3unmdUFpSzWOmNkgJjrDpbyR7Ctl9 WX/6j+w16+gWSTOyWqINA08= X-Received: by 2002:aa7:c60e:: with SMTP id h14mr12964037edq.40.1642290318922; Sat, 15 Jan 2022 15:45:18 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id e26sm1407022edy.36.2022.01.15.15.45.18 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Jan 2022 15:45:18 -0800 (PST) Date: Sat, 15 Jan 2022 23:45:18 +0000 From: Wei Yang To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com Subject: Re: [PATCH] mm/page_alloc: clear node_load[] in function build_zonelists Message-ID: <20220115234518.4q2yhb3mz2sg76iz@master> Reply-To: Wei Yang References: <20220115230002.490-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220115230002.490-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 15, 2022 at 11:00:02PM +0000, Wei Yang wrote: >static variable node_load[] is a helper variable during build zonelist. >On each turn for building zonelist, node_load[] is cleared. So this is >proper to do this in function build_zonelist. > Hm... sounds I missed some important part of this operation. Please forget this one :-( >Another side effect is, #ifdef CONFIG_NUMA could be removed since >node_load[] is only defined when CONFIG_NUMA is set. > -- Wei Yang Help you, Help me