Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2451193pxb; Sun, 16 Jan 2022 21:19:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8scUYgWYA3PhcGHo/S1VUdPaMnWTdVwekIRR/DMEn0K1d5Sbl1AVOOfVoRDsIVb+0+GvU X-Received: by 2002:a17:90b:38ca:: with SMTP id nn10mr11387862pjb.136.1642396747878; Sun, 16 Jan 2022 21:19:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642396747; cv=none; d=google.com; s=arc-20160816; b=a3L/NCarBnEU16Q+AUdBfxBfsYzasPVOMnl67qGjnT4hp1Q5HAg1u8gZ/A5ofD9JPD fZRATFjDReohImYxy6FwKwIsMdYeL42tGy/twRAHxutYnVc7DM24VOcxe+c8zP6i9DQq TM/TGufs/08idW3U8xIxZLMzG1X2tRcFhDsRfJnRIJ8garTU1b9AoHa79+NG639Kqlb/ Hre4Kq3HW13wx4tUmDCo+oI48s3S3zYs9y02MgFA79u0CaMjqZpltJHSO6h8G80WpIU+ X6Mj/Gkskh8A/zQFo1e2HP3PGpwehvX3ubx6G2cmyTv4y/b5zJ2HBb/P0XjxdMyk4m2F ZXaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=g+tH5RFZbLqj0pRi0CGBafEbLbjFIXmVpymn957LC1g=; b=LKgST/87b7t1UGO95arIqflMh+QEVGm47ZD6b3jL4xh/EivrUsiF42YnuQOag+3YYR tW/lgRb7vlyX4FfOpVCYpvHs4cNyctP5IprJnAYYDvJtlACbir7lquap1MQiofYK3pJo bLRRjwsSBLcVv2Nu0I7aGP3aSEDfCDSm/6aliIOl1lbH4KFx02SSLY5Z4lCGhCLcsLok oKJipfbHD2y5PxrYAjB4RffLvNaq6POKrtzImOzcttmsdW19DJ0ebPibb2WAqQIB8y3I Cnjov0Q1T4eJXSv33LWA123hPP0QBHYlDgJG3BZzsKmNN42ADoObQuxe8jyB4vp7MWeZ RZzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u7si13203666pfg.3.2022.01.16.21.18.55; Sun, 16 Jan 2022 21:19:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234521AbiAPHgV (ORCPT + 99 others); Sun, 16 Jan 2022 02:36:21 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:12706 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234512AbiAPHgU (ORCPT ); Sun, 16 Jan 2022 02:36:20 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R661e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0V1wSe6h_1642318566; Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0V1wSe6h_1642318566) by smtp.aliyun-inc.com(127.0.0.1); Sun, 16 Jan 2022 15:36:07 +0800 From: Shuai Xue To: bp@alien8.de, rric@kernel.org Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, ardb@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, xueshuai@linux.alibaba.com, zhangliguang@linux.alibaba.com, zhuo.song@linux.alibaba.com Subject: [PATCH v3 0/2] EDAC/ghes: refactor memory error reporting to avoid Date: Sun, 16 Jan 2022 15:36:01 +0800 Message-Id: <20220116073603.11517-1-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211210134019.28536-1-xueshuai@linux.alibaba.com> References: <20211210134019.28536-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ghes_edac_report_mem_error() in ghes_edac.c is a Long Method and have Duplicated Code with cper_mem_err_location(), cper_dimm_err_location(), and cper_mem_err_type_str() in drivers/firmware/efi/cper.c. In addition, the cper_print_mem() in drivers/firmware/efi/cper.c only reports the error status and misses its description. This patch set is to refactor ghes_edac_report_mem_error with: - Patch 01 is to wrap up error status decoding logics and reuse it in cper_print_mem(). - Patch 02 is to introduces cper_*(), into ghes_edac_report_mem_error(), this can avoid bunch of duplicate code lines; Changes since v2: - delete the unified patch - adjust the order of patches - Link: https://lore.kernel.org/all/20211210134019.28536-1-xueshuai@linux.alibaba.com/ - Thanks Borislav Petkov for review comments. Changes since v1: - add a new patch to unify ghes and cper before removing duplication. - document the changes in patch description - add EXPORT_SYMBOL_GPL()s for cper_*() - document and the dependency and add UEFI_CPER dependency explicitly - Link: https://lore.kernel.org/all/20211207031905.61906-2-xueshuai@linux.alibaba.com/ - Thanks Robert Richter for review comments. Shuai Xue (2): efi/cper: add cper_mem_err_status_str to decode error description EDAC/ghes: use cper functions to avoid code duplication drivers/edac/Kconfig | 1 + drivers/edac/ghes_edac.c | 196 +++++++----------------------------- drivers/firmware/efi/cper.c | 82 +++++++++++---- include/linux/cper.h | 3 + 4 files changed, 102 insertions(+), 180 deletions(-) -- 2.20.1.12.g72788fdb