Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2501070pxb; Sun, 16 Jan 2022 22:55:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCQ3nsE2sXnsw4BLGfo9BdIVn+TZ2JigjY48cZoSGi9Tv0wSxJ62td7vbz4WaXhNoyQ0f6 X-Received: by 2002:a05:6a00:1d26:b0:4c0:2388:73c6 with SMTP id a38-20020a056a001d2600b004c0238873c6mr20312906pfx.69.1642402511801; Sun, 16 Jan 2022 22:55:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642402511; cv=none; d=google.com; s=arc-20160816; b=PRt5EyuwZEg0prUXMm0qZrtlE8Zos+IvT+EoNfR8zowp+WW9gLEtga8pBfu3yzveiI FIsnv20uJHNueoO6jDte1PqSI3oxcItSMfmRDVOu2iB8RDdHtGm/31cSrae9o+b8/ViH eGx8TXaYCq02e0DCvs3t5WkiBMR/QwPj9yM/JdrO+qt3JwFQgS/Pd6dijtRjVMiOR6M9 fSDjHKBVdS1UKZvRjbfl6AhOevNmPc+vx6EQsgDRMWzPZBNIDG5OKDsMd07nh0xxYZbD yYbfo8VNN90rfXb9gfxrX08Dd6ckvUA6Ud6B6JeCVFXUyBIIZNK2Tb4K9XLs3/HpEJBw d4hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=g0ejI+v9kTjOBRp5hp1TQV/Duaiql3D8eEQKfIRKX3k=; b=Hp3yRocqPa6qg3HdjJzIIox2UxpWOYNK6AmQmpFlw1KxOLT8G5qG/oN5ChX9M5aMW/ 3Nk6ls2nC+HX3LWMoBRlOlpHbRZScZFjOcwF1mwGshPAwzaXvEmVFDaspEgDmvExrvaN PBJL8pndWohPTh+uUlRDWPwTryCQD997nv/3hkGno3jCPPE8wluLC3jhReh+S86uPT9P q5T6F/VhEzX82ZCk9hYxsU7z9TYUwNFgNtjewpJOZW7tZvygJin98d+IaV/WYRkggsvA z0dlJheB63kKXWIu/G1qAPeHJAbRrhdae0Mc4zsQEgTXa30d/Nc4qLxZM0gZjqvpOfe/ 8UTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="QzyM8HM/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si13808208pgl.244.2022.01.16.22.54.55; Sun, 16 Jan 2022 22:55:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="QzyM8HM/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235034AbiAPMI0 (ORCPT + 99 others); Sun, 16 Jan 2022 07:08:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235031AbiAPMIY (ORCPT ); Sun, 16 Jan 2022 07:08:24 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 966D2C061574 for ; Sun, 16 Jan 2022 04:08:24 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id a12-20020a0568301dcc00b005919e149b4cso16184553otj.8 for ; Sun, 16 Jan 2022 04:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0ejI+v9kTjOBRp5hp1TQV/Duaiql3D8eEQKfIRKX3k=; b=QzyM8HM/9pPFc3Jt/terXNWjGC/FCIiDoRyGCgZ9GxVJg+GtqL92dk7aEkM8l9DXmj O7knAUpO43nsRvNbjHRMiWczHCO4hP45URmNFSr1Evx1eMMe5egqoicrg0h4MxgcmR2Z ShHMNPDfNdCzanCeSqOrdiUJDMB8O9XtTL145OHU07BC81yP0tZ8wfRdq0T58AVUaNmn +oOIeEJPqC+lKHX2VyHZ8sDv8AODtH9Y8T3YBvlfM9wq7ZY1LRhpHg1Dll11p3Fe9rqm 2O2jeSaTv9Qqn3MFz7h+e6ezTc9lq0PO5C+zSCj4NJCPQqw0Q+q4NWhZtD79kR7LjXDC DFQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0ejI+v9kTjOBRp5hp1TQV/Duaiql3D8eEQKfIRKX3k=; b=OKfLd3fzSmluRX+PwrYGnltRm4WBEXzrvsVxpjWsUPzsy7sXKPRSx9C5G9V7t9B/ZY nxnqCs9QpJ86VECHxCR7IGAl8O+LDq7tWqUZGXDRf4ObUkW0ROkWgL3Da5Zru5mdPrSI tMEwzvFiETXehpeEJxW0WKkSzuaCp6I33TcmZJG85BlD9Hk8qV2bAXiO3jplkoSeEkmz vBEXO8BYEIK7O6j6er/kHZFiVMYZMNgIetkSw4FZQxZOUnnYurl7kfk2O7M9r7iusJ4J q7d+0JM2OWYEVf8p2t+AitvhxGMIEE+QAmbvRn6MOp7l2z901XDa1Olv7zxm+RFsAQg8 dN0A== X-Gm-Message-State: AOAM532yzKa2EJENY28DDFZOmT0CLLrH0bJ0pw++nleoK3OWSG6q/e7G hKDAglpjVE9waydJnwKjMH/dWZnwRCkvx8n8IdqOlA== X-Received: by 2002:a9d:465:: with SMTP id 92mr12893701otc.35.1642334903987; Sun, 16 Jan 2022 04:08:23 -0800 (PST) MIME-Version: 1.0 References: <20220114065949.24126-1-linmq006@gmail.com> In-Reply-To: <20220114065949.24126-1-linmq006@gmail.com> From: Linus Walleij Date: Sun, 16 Jan 2022 13:08:12 +0100 Message-ID: Subject: Re: [PATCH] mfd: ipaq-micro: Fix IRQ check in micro_probe To: Miaoqian Lin Cc: Lee Jones , Greg Kroah-Hartman , Alessandro Gardich , Dmitry Artamonow , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 7:59 AM Miaoqian Lin wrote: > platform_get_irq() returns negative error number instead 0 on failure. > And the doc of platform_get_irq() provides a usage example: > > int irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > > Fix the check of return value to catch errors correctly. > > Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij