Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2501067pxb; Sun, 16 Jan 2022 22:55:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwA+L5T7jpmppKlMDHusZkiYFuaup79OqLNUyyIygIU2P94Th9oHcRh2CSf8zCNlcpiOk3g X-Received: by 2002:a17:902:d48d:b0:14a:98e3:f969 with SMTP id c13-20020a170902d48d00b0014a98e3f969mr11312396plg.9.1642402511791; Sun, 16 Jan 2022 22:55:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642402511; cv=none; d=google.com; s=arc-20160816; b=oW69UV88hEDL/DVxfT3tbUKx/WBC0k7Zyjg8tPGI0eOY2wul8XXJlMRILstUn0HhzR bH+KVIzuEOgwrMiaeuIIsPDimD2gMqCtmdPiQAr/+0AvqtzHWy0gRUdifnXic+LV7rxy w9kfySgJazpRll1s/mAkNhlKKnWEmwNTxT4Ko7K/ZQ4eI6i2DxLa8WmMgaTrZ3kGi+Ek /++zP245JJZm/8K3Z4/6JxDHTZVXIN/mGnbq3m1U1HobviKBQSEpnY1AX5cYBvpLp5y4 RxnfzsB0GOfzBhdxiDKdIPA+nWjbzr6cykx7ezxjnUSS/YkXU8qUnEPGz6FeOeQGX1FV 94Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=kNXnIX6RDJdtlZPD9+1UW8TCX7PYSU+tj75Zl+vyUO4=; b=AfFog+7XHidS5FeBdBYbA66QYfHsBUx6A+DyVEErDkm+PJDBZaPZKZoOIZfpdzQ9Kn EEEmpLOhRJQ2QnMmY+SSh89aVYv5kZLls2YTeEzpeCkYxqJubKe4DWCVCra9FTWwyzEK 2RHJId+tUgJJTRXGfnhAyHJy52YVWNpQ4vStt5sxN1iWgxqoVs1mQK09qKLWREcD7QBS ern+8Asp1ptH1c/isuxY1yfQ6VlqEBE7t8LAzUsfy+PBKoQ3DaCD1D9Pcze+YRi83WYY LSMEi4ZJ1ig43X2vuj7pm5gK2/hBBDrhNiCFzMvJEoQvMhkisYbFTaqbecGpAegEqrop P9qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DBLiHXCL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si7206905pls.219.2022.01.16.22.54.54; Sun, 16 Jan 2022 22:55:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DBLiHXCL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235020AbiAPMHs (ORCPT + 99 others); Sun, 16 Jan 2022 07:07:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235015AbiAPMHq (ORCPT ); Sun, 16 Jan 2022 07:07:46 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE5ADC06173E for ; Sun, 16 Jan 2022 04:07:46 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id s9so19342727oib.11 for ; Sun, 16 Jan 2022 04:07:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kNXnIX6RDJdtlZPD9+1UW8TCX7PYSU+tj75Zl+vyUO4=; b=DBLiHXCLxN1uq/uKSNR3y1nJSqPKpE2i5uNfleicUU8F6GQf1QGbCLk2W/wMZvLUB8 I1UevA001hhXsayZHUXVT4z6jlO5ULWJEAZZmFF9nZYl9kQll4hNM0x8AXMEIeevPrm1 KEmYUFirkHg2Toi5bBoqpqzOBVMAOS2DPQQryXOgsZcVf39BSx4hZvi+Ue8wWfPTwcES vgjyLjCVSxXj19NrwR8SviXhlP/el7rDt5QLZIOJ+v5PlqbCFfYD+6y5Ptu8KwIwgVbE YCjXzDNpEP/N8iSM0nGIMSFZrPfA31Gkpg9ZjThATQ6LQ2kz5pxUTtxFt4H16b3HtpST Pvdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kNXnIX6RDJdtlZPD9+1UW8TCX7PYSU+tj75Zl+vyUO4=; b=xCxtmLOiK5HdEZFLYHkWkXaRL6dHvtve1gNzTfmOa0sp3z0UxLAEkyV0VG4FIoRjQb nW79YVrNj8xbz/+qk3uVIo+xiDVqcab8wBG8D5gLbI5qHhQyHh26DDjeNi29oAeWF9YC ImwjQ3OPTYY81RIdmoxOkvOdkIzoER3wjiJE0KCxJFK2qVXP7IYtJpVrro5OBZa0f9th v14rCV8NMfsIQGg2AxwEKGd+X8x6N+cW5GCimDuiRdxThmM7VKU4I5ZZPC0t2MVFEanM QNxvZ2v1sAGAMGv5MrwD08nDru/w/ZYx7vyTjJP7LfETKO+fbXWGIC7bz63BMaDQokro Ea/A== X-Gm-Message-State: AOAM531AjOd6/dvNv8Dqhp4GfBrThOJYKC6atpkbJLVFdo9GzGhO3iYg jaFT8icWiZTnK1JssiRSYVK2p5Afm42tbCNO3vM31A== X-Received: by 2002:a05:6808:2097:: with SMTP id s23mr9512934oiw.132.1642334866142; Sun, 16 Jan 2022 04:07:46 -0800 (PST) MIME-Version: 1.0 References: <20220114065125.21208-1-linmq006@gmail.com> In-Reply-To: <20220114065125.21208-1-linmq006@gmail.com> From: Linus Walleij Date: Sun, 16 Jan 2022 13:07:34 +0100 Message-ID: Subject: Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe To: Miaoqian Lin Cc: Bartosz Golaszewski , Thomas Bogendoerfer , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin wrote: > platform_get_irq() returns negative error number instead 0 on failure. > And the doc of platform_get_irq() provides a usage example: > > int irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > > Fix the check of return value to catch errors correctly. > > Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij