Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2501072pxb; Sun, 16 Jan 2022 22:55:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0dn51xLpUhtje96f33sS2Zj+8flI/6Nh37xMaEnkzxu2o2I+jIrcjpw+orQXBhm39nZ7R X-Received: by 2002:a17:902:6b4a:b0:149:7c73:bd6f with SMTP id g10-20020a1709026b4a00b001497c73bd6fmr20613485plt.46.1642402511816; Sun, 16 Jan 2022 22:55:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642402511; cv=none; d=google.com; s=arc-20160816; b=I1b/CuC8vzFZPMqKuAGdrGU2zBAV1wqfFTetqTJ/OiNpJUcMeps/Kjdme188DOvcSl sv+w8OgiZV0DVTP1APR4f2354eT7gKnsuE/X4aWLNWpm3gEAD97lMylsrMFCgnFxghEY zlVQa651lVDHHnhVR9jaOS5BwkV3nDtgKnTpM+IFGfjf1Gm74MiHaVy6N3L2UM2KEGd8 Ef+ctbb+H8teguJYj3wRCC6QDmkvfvHrl4NXhBvuPXdkXGaNsIZTmbEBqcJNTaJAphQ0 toUoVbHUBTPo4DC+AyCjmIsJN4PgmYqAmole37yavpB6r0KA0hCd1XfHyeKZBUrK8Vaa KKNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7o2yHBJnbdgBA14paBxnQ07Miq57N45X/orHzH3UYOU=; b=oT3YeX8OSMb8/Z1DzMcJDjALJqTLYeKy/BjOCB5DL16E2CB+WC3PgexkirLNQhS42x IxRjtcIQ8YMDj6tg7PcDbjMQc+g8NSZel/ArPsIbC26ZNp/AbSgOwB9gsTsJjhuU+sB0 LHLgMaXSdRD2TKJol1lWi4m8LrJbtCF1ZUXZHH/BTvgB+PoRlCf0SOX9UxagRYgC1GkR aSJSvDqwqwPH/HNHziCFcTN9vNg7Xm0CC8L/OAajHYQ4+vxMMByvrCjfYxHFzkKr9SOR FVCJUupYwyQ9TsXM9oQm0jAXhG76EUX0QXeFuIpnq+XdFqt7aPMrd7Fg15An8iriPhjr jFVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LO+72frJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si15123277pfu.289.2022.01.16.22.54.52; Sun, 16 Jan 2022 22:55:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LO+72frJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235012AbiAPMHK (ORCPT + 99 others); Sun, 16 Jan 2022 07:07:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232954AbiAPMHJ (ORCPT ); Sun, 16 Jan 2022 07:07:09 -0500 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DAECC06161C for ; Sun, 16 Jan 2022 04:07:08 -0800 (PST) Received: by mail-ot1-x331.google.com with SMTP id t4-20020a05683022e400b00591aaf48277so16163106otc.13 for ; Sun, 16 Jan 2022 04:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7o2yHBJnbdgBA14paBxnQ07Miq57N45X/orHzH3UYOU=; b=LO+72frJu+DNTvMhQZVhuGanlYhZPe4ZG9J8lwuaPGnb79xbpLy/Fvdo2kesOn2Rin 81WFCPtwZYnCHbTZ10vA+fp0fAnIOnKvjqHTM1RIwCnAYgPrWt115M8kwke52A+BXuYV uMTdvQEQN6pZwYYZm868xk/PtYzlm1Xx2Rp0wmtwoqhDIkt55Ajp9GMn0zNQzzHYfGlc uw9mWbRYRj3rk1by15iR97Mf+OIdaDL8uj0P+igWbFmgei7VgSzWLKFmL9gGtEwkcKRa jZftuMKhTo8GqhPWPr8C/t/bUIXmOH8plS1PFfhuJERBOgEnUzpX8dAWVweJUg5iILN+ gVDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7o2yHBJnbdgBA14paBxnQ07Miq57N45X/orHzH3UYOU=; b=GkqqLRQWzM8IaRcQDx4pjBqDnAydDAdGuxtG9K9sXp97ysVDPeHLNJE4Lfac04+RSh vlqCnBRkuQFF2or8UMe7870LS7bdRns4RDcgKZDYrBNRHSBf0/RLwWCoENYDwim5sxxk ZbOG2l5fJudFf/W8oDynWRa8PC/RRBIxxAGHGa+gAEitj8vhhmAtyd1hG7jBzTNxn6Kz DCEk+uDCVrXXmi6TafkMNcUNFJ+j+nWVNAaUQCDMnJoIQcCey37o9uLdi3IK0nutAty6 F4uMZBfoN9MEFIBuAGSJoj2Ufq0tU8TEEgpQJwvkIHYJVmPptt+4WszU3i2eXZGgXoe1 G8Xw== X-Gm-Message-State: AOAM532+jxjXesHCShMfgSC+qCEIdLb+icWKO4QS9xT2nzJWGsJ4n0X6 BUDkMRuGjbsI+7G9EHVSGzg1ydPceKX8K7RxQNtyfw== X-Received: by 2002:a9d:465:: with SMTP id 92mr12890735otc.35.1642334827966; Sun, 16 Jan 2022 04:07:07 -0800 (PST) MIME-Version: 1.0 References: <20220114064821.20200-1-linmq006@gmail.com> In-Reply-To: <20220114064821.20200-1-linmq006@gmail.com> From: Linus Walleij Date: Sun, 16 Jan 2022 13:06:56 +0100 Message-ID: Subject: Re: [PATCH] gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe To: Miaoqian Lin Cc: Bartosz Golaszewski , Ran Wang , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 7:48 AM Miaoqian Lin wrote: > platform_get_irq() returns negative error number instead 0 on failure. > And the doc of platform_get_irq() provides a usage example: > > int irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > > Fix the check of return value to catch errors correctly. > > Fixes: 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij