Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2535910pxb; Sun, 16 Jan 2022 23:59:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhPqKzem/kR9jy5/ds4CpQNsn5wtntR/vbWPwf2hrWiU3i4opwE4oFCs38e3uW1JUeWdaj X-Received: by 2002:a17:902:eb42:b0:14a:40eb:6d2 with SMTP id i2-20020a170902eb4200b0014a40eb06d2mr20650650pli.67.1642406393149; Sun, 16 Jan 2022 23:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642406393; cv=none; d=google.com; s=arc-20160816; b=TegSydz4fCoi36P/jK5bK3LI/3PCbIl7ibOUuOrx676+nkMVz5G/heBXOed3hZxMb1 htbok3bqln/MzpW//c78zw7EWOj5bk6Qqp67mDIwsxPoceL6Gu5wMk2HUvRq9rbqeiBL qxDvRy4X6+VOEfBEbtlKXMu6CsZeDcwmrmLkpswbm/xxZR8F5JNhLdzY3PHXIxN4D8nV GZFbxPSw/RV7H97ppQPvFW4QQFIRIghWND7JWUgiaVdSdqxWEyJph5ILuTww9jWZndgQ CYMfMi3zoRvzl1bVLTaDRbj3PJ6yJZof4qsgdgTfHht4hSc1KmclN5dVPO6oR18nslO6 bb2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=EkDyax28DfxGk59dEBmvEZxearlQhbzu7EsQPgVdO54=; b=lPt/NdQ/X6S76FwT7SChnTCxasjhwjkZF4tfaEkcsaNuhUqukeCy5EBwAO8J9SznwC LzdhzCm0hGgHyBcmE9tykFxK3bcc4n3TGAnCv16WQ/zX7sZrx8FJTgDWSuf+8h9DPTDV Y+7/Dr8M9gIsITD9Y7PWdYHPfusxMpPLjcXuVJO5vPxZzPf2ESvQk0nJ8zQaxCxhu+dZ sWr3h+vX5c22gx1vRDF/ZWrje1uT2pcl1dX/zj+mxr519ExRKj/ajM9VO01fn+K613+P K/rvKr4ZZy4h7Yy8UxvkW53weRtq9C7v4PP1B5IEWtXIbsemHsoi7+tqmOxA1w1faZVD zzDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 33si13874131pgw.701.2022.01.16.23.59.42; Sun, 16 Jan 2022 23:59:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235379AbiAPNpU (ORCPT + 99 others); Sun, 16 Jan 2022 08:45:20 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:53488 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233335AbiAPNpJ (ORCPT ); Sun, 16 Jan 2022 08:45:09 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 59042200230; Sun, 16 Jan 2022 13:45:07 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id CE2F380326; Sun, 16 Jan 2022 14:24:45 +0100 (CET) Date: Sun, 16 Jan 2022 14:24:45 +0100 From: Dominik Brodowski To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, tytso@mit.edu Subject: Re: [PATCH 2/7] random: cleanup integer types Message-ID: References: <20220113154413.29513-1-Jason@zx2c4.com> <20220113154413.29513-3-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220113154413.29513-3-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Thu, Jan 13, 2022 at 04:44:08PM +0100 schrieb Jason A. Donenfeld: > Rather than using the userspace type, __uXX, switch to using uXX. And > rather than using variously chosen `char *` or `unsigned char *`, use > `u8 *` uniformly for things that aren't strings, in the case where we > are doing byte-by-byte traversal. > > Signed-off-by: Jason A. Donenfeld > - unsigned short reg_idx; > - unsigned char count; > + u16 reg_idx; > + u8 count; As you do not change other unsigned shorts to u16, and that change is not explained in the changelog, please defer that to a separate patch. Otherwise, feel free to add: Reviewed-by: Dominik Brodowski Thanks, Dominik