Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 16 Jan 2022 14:24:59 +0100
From:   Dominik Brodowski <linux@dominikbrodowski.net>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-kernel@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 5/7] random: rather than entropy_store abstraction, use
 global
Message-ID: <YeQcq0akOPjUU5gW@owl.dominikbrodowski.net>
References: <20220113154413.29513-1-Jason@zx2c4.com>
 <20220113154413.29513-6-Jason@zx2c4.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220113154413.29513-6-Jason@zx2c4.com>
Precedence: bulk

> -static void __mix_pool_bytes(struct entropy_store *r, const void *in,
> -			     int nbytes)
> +static void __mix_pool_bytes(const void *in, int nbytes)
>  {
> -	trace_mix_pool_bytes_nolock(r->name, nbytes, _RET_IP_);
> -	_mix_pool_bytes(r, in, nbytes);
> +	trace_mix_pool_bytes_nolock(nbytes, _RET_IP_);
> +	_mix_pool_bytes(in, nbytes);

Can the parameters of these tracepoints be modified, or does this break
any part of our API?

I haven't looked at the tracepoint bits in detail; otherwise, the changes
look good:

	Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net> # random.c only

Thanks,
	Dominik