Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220112100046.68068-1-krzysztof.kozlowski@canonical.com> <20220112100046.68068-2-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20220112100046.68068-2-krzysztof.kozlowski@canonical.com>
From:   Alim Akhtar <alim.akhtar@gmail.com>
Date:   Sun, 16 Jan 2022 20:58:16 +0530
Message-ID: <CAGOxZ521MhOb+rv+NPCOJq60+CrpsmRR6boWUK5tc_H5wXDmFw@mail.gmail.com>
Subject: Re: [PATCH v3 1/4] ARM: dts: exynos: split dmas into array of
 phandles in Exynos5250
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Andi Shyti <andi@etezian.org>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Pratyush Yadav <p.yadav@ti.com>, linux-spi@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Sam Protsenko <semen.protsenko@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 13, 2022 at 4:19 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> "dmas" property should be rather an array of phandles, as dtschema
> points.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Andi Shyti <andi@etezian.org>
> ---

 Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 139778928b93..102bb57bf704 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -496,8 +496,7 @@ spi_0: spi@12d20000 {
>                         status = "disabled";
>                         reg = <0x12d20000 0x100>;
>                         interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
> -                       dmas = <&pdma0 5
> -                               &pdma0 4>;
> +                       dmas = <&pdma0 5>, <&pdma0 4>;
>                         dma-names = "tx", "rx";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> @@ -512,8 +511,7 @@ spi_1: spi@12d30000 {
>                         status = "disabled";
>                         reg = <0x12d30000 0x100>;
>                         interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> -                       dmas = <&pdma1 5
> -                               &pdma1 4>;
> +                       dmas = <&pdma1 5>, <&pdma1 4>;
>                         dma-names = "tx", "rx";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> @@ -528,8 +526,7 @@ spi_2: spi@12d40000 {
>                         status = "disabled";
>                         reg = <0x12d40000 0x100>;
>                         interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
> -                       dmas = <&pdma0 7
> -                               &pdma0 6>;
> +                       dmas = <&pdma0 7>, <&pdma0 6>;
>                         dma-names = "tx", "rx";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> --
> 2.32.0
>


-- 
Regards,
Alim