Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <259abc88-58ac-9101-21a1-5130168fcdac@redhat.com>
Date:   Sun, 16 Jan 2022 18:31:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2] drivers/firmware: Add missing platform_device_put() in
 sysfb_create_simplefb
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     bp@suse.de, daniel.vetter@ffwll.ch, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, tzimmermann@suse.de
References: <735d2b47-227f-f09d-ddd6-28bc82a066a5@redhat.com>
 <20220116121654.7730-1-linmq006@gmail.com>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20220116121654.7730-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/16/22 13:16, Miaoqian Lin wrote:
> Add the missing platform_device_put() before return from
> sysfb_create_simplefb() in the error handling case.
> 
> Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> Changes in v2:
> - Use goto label to avoid duplicating the error code logic.
> ---
>  drivers/firmware/sysfb_simplefb.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat