Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <tencent_949564FE01410898F3734D38FA284CC2E909@qq.com>
In-Reply-To: <tencent_949564FE01410898F3734D38FA284CC2E909@qq.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 16 Jan 2022 23:19:46 +0200
Message-ID: <CAHp75VfxsBN4E3aeME8HKWtjuOPC2meuJ4hweOcXf-te5kotYg@mail.gmail.com>
Subject: Re: [PATCH] gpio: merrifield: check the return value of devm_kstrdup()
To:     xkernel.wang@foxmail.com
Cc:     Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 16, 2022 at 10:21 AM <xkernel.wang@foxmail.com> wrote:
>
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> devm_kstrdup() returns pointer to allocated string on success,
> NULL on failure. So it is better to check the return value of it.

Before if devm_kstrdup() fails, the GPIO driver will be registered
without pin control, now it will fail the registration.

It's not that I'm against the patch (the above is quite unlikely and
brings a not fully working system on most of the known platforms with
this SoC), but you need to do better your analysis. That said, please
rethink a bit the commit message you put there and send an updated
version.


-- 
With Best Regards,
Andy Shevchenko