Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946445AbXBCKvl (ORCPT ); Sat, 3 Feb 2007 05:51:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946446AbXBCKvl (ORCPT ); Sat, 3 Feb 2007 05:51:41 -0500 Received: from ns.suse.de ([195.135.220.2]:48508 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946445AbXBCKvk (ORCPT ); Sat, 3 Feb 2007 05:51:40 -0500 From: Andi Kleen To: =?utf-8?q?Fr=C3=A9d=C3=A9ric_Riss?= Subject: Re: 2.6.20-rc7: known regressions Date: Sat, 3 Feb 2007 11:51:16 +0100 User-Agent: KMail/1.9.5 Cc: Andrew Morton , Matt Domsch , Adrian Bunk , Linus Torvalds , Linux Kernel Mailing List , Eric Van Hensbergen , Trond Myklebust , Neil Brown , Stephen Hemminger , Benjamin Herrenschmidt , Jeff Garzik , "Eric W. Biederman" , Francois Romieu References: <200702031058.13830.ak@suse.de> <1170499668.31373.35.camel@funkylaptop> In-Reply-To: <1170499668.31373.35.camel@funkylaptop> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200702031151.17220.ak@suse.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 30 > +#ifdef CONFIG_X86_32 > +#define efilinkage asmlinkage > +#else > +#define efilinkage > +#endif No ifdefs, this should be somewhere in the headers for the EFI supporting architectures But I suspect you could actually get away with just using asmlinkage (after reviewing the ia64 asmlinkage I think it's ok) x86-64 when it is ever implemented will always need asm stubs though because it uses completely incompatible calling conventions. > + > +typedef efilinkage efi_status_t efi_get_time_t (efi_time_t *tm, > + efi_time_cap_t *tc); I assume you have double checked it actually works? (i vaguely recall some issues with applying attributes to typedefs). If not you would need to put them to the declarations. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/