Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YeITMG7bKozB2xVQ@bombadil.infradead.org>
In-Reply-To: <YeITMG7bKozB2xVQ@bombadil.infradead.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 17 Jan 2022 07:38:25 +0200
Message-ID: <CAHk-=wjCajUWAZBNrQv3zrrjZBH7e7x2UrQ2n18+yk3TpGD9ag@mail.gmail.com>
Subject: Re: Modules updates for v5.17-rc1
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     Jessica Yu <jeyu@kernel.org>,
        Colin Ian King <colin.king@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Yu Chen <chen.yu@easystack.cn>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-modules@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jan 15, 2022 at 2:20 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> Although this change was only merged on January 11th, the patches have
> been being reviewed since early december. There was at least one fix
> already found for it and merged.

Grr..

And that's exactly why it matters not about "being reviewed", but when
they were in linux-next etc.

I've pulled this, but consider this a complaint. Things should not be
"reviewed" before the merge window. They should be ready and merged
and have actually seen some testing.

Review is good. But nothing beats actually being out there and
actually seeing real-life testing (of course, linux-next probably
mostly gets build-testing, but what testing it gets is still better
than not being there).

               Linus