Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946450AbXBCLIK (ORCPT ); Sat, 3 Feb 2007 06:08:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946451AbXBCLIJ (ORCPT ); Sat, 3 Feb 2007 06:08:09 -0500 Received: from ug-out-1314.google.com ([66.249.92.168]:24838 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946450AbXBCLIG (ORCPT ); Sat, 3 Feb 2007 06:08:06 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=hLRyXvOc9z4RIKmXzKxaiYMS2fb3xq6hjCbMjQJp1u/D5BxbrlQC9yJxmys5TDxdpZpEiMfe3AjSll6UM1AhmdBiYKLqpzGgtp70+qUYeNBM5c0McpdxjG6LC7pCk3ASn+BVMF916Q56YB5rTBXt4NaKpi7HJWnUV0svv+rOr0A= Subject: Re: 2.6.20-rc7: known regressions From: =?ISO-8859-1?Q?Fr=E9d=E9ric?= RISS To: Andi Kleen Cc: Andrew Morton , Matt Domsch , Adrian Bunk , Linus Torvalds , Linux Kernel Mailing List , Eric Van Hensbergen , Trond Myklebust , Neil Brown , Stephen Hemminger , Benjamin Herrenschmidt , Jeff Garzik , "Eric W. Biederman" , Francois Romieu In-Reply-To: <1170500244.31373.40.camel@funkylaptop> References: <200702031058.13830.ak@suse.de> <1170499668.31373.35.camel@funkylaptop> <200702031151.17220.ak@suse.de> <1170500244.31373.40.camel@funkylaptop> Content-Type: text/plain; charset=utf-8 Date: Sat, 03 Feb 2007 12:08:01 +0100 Message-Id: <1170500882.31373.47.camel@funkylaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 25 Le samedi 03 février 2007 à 11:57 +0100, Frédéric Riss a écrit : > Le samedi 03 février 2007 à 11:51 +0100, Andi Kleen a écrit : > > > + > > > +typedef efilinkage efi_status_t efi_get_time_t (efi_time_t *tm, > > > + efi_time_cap_t *tc); > > > > I assume you have double checked it actually works? (i vaguely recall some > > issues with applying attributes to typedefs). If not you would need > > to put them to the declarations. > > Of course, I tested 10 suspend/resume cycles. This is with gcc 4.1.2, I > guess other compilers could mishandle it. Would you prefer the version > putting asmlinkage inside the struct definition? But then it then throws 'assignment from incompatible pointer type' warnings in efi.c. This would need fixing in arch/ia64 and arch/i386. Or should I put it in the typdefs _and_ in the struct to be safe ? Fred - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/